Repository addresses must not contain the .git suffix

[0x2b3bfa0]

The error on #562 happened because the user configured a repository address with the .git suffix (e.g. https://github.com/user/repository.git) as the RUNNER_REPO / --repo option. It would be nice to clarify this somewhere in a troubleshooting section, if we plan to have it.

Desiderata, part of #514

[DavidGOrtega]

Actually we do a cleanup of '.git' when inferring the repo. Should we apply it always?

[0x2b3bfa0]

@DavidGOrtega, this only happens in the cases where the repository address is inferred from the Git repository itself, but not when it comes from the RUNNER_REPO environment variable or the --repo option. See #562 for a practical example.

cml/src/cml.js

Line 77 in 498fcd1

this.repo = uri_no_trailing_slash(repo || git_remote_url());

cml/src/cml.js

Lines 30 to 36 in 498fcd1

	const git_remote_url = (opts = {}) => {
	const { remote = GIT_REMOTE } = opts;
	const url = execSync(`git config --get remote.${remote}.url`).toString(
	'utf8'
	);
	return strip_auth(git_url_parse(url).toString('https').replace('.git', ''));
	};

If we can safely remove the suffix from every address, let's do it in the code. I can't think of any case where we shouldn't remove it, but I'm not completely sure.

[0x2b3bfa0]

We can choose to:

1. Keep the current logic and document the issue
2. Remove the suffix automatically in every case

I find the latter rather convenient, but I still don't know if there is any special case^{[citation required]} where this behavior can produce unexpected results. It seems pretty safe to me.

[DavidGOrtega]

We can choose to:

1. Keep the current logic and document the issue
2. Remove the suffix automatically in every case

I find the latter rather convenient, but I still don't know if there is any special case[citation required] where this behavior can produce unexpected results. It seems pretty safe to me.

Agree. I can't see anything bad with it.