Remove helm #625
Remove helm #625
Conversation
kalantar
commented
Apr 19, 2021
kalantar
commented
- Replaces update doc in response to changes to install #618 which got polluted with changes from another change to master.
- Resolves [Feature Request] Update knative canary with progressive rollout instructions to explicitly install RBAC rules for helm #624
- Updates version of iter8-install from 0.3.0 to 0.3.2
- Introduces environment variable GIT_ACCOUNT used by the install scripts. This can be set for manual testing against a fork.
| @@ -30,6 +30,7 @@ if [[ ! " ${NETWORK_LAYERS[@]} " =~ " ${1} " ]]; then | |||
| fi | |||
|
|
|||
| # Step 1: Export correct tags for install artifacts | |||
| export GIT_ACCOUNT="${GIT_ACCOUNT:-iter8-tools}" | |||
| export TAG="${TAG:-v0.3.0}" | |||
There was a problem hiding this comment.
Tag needs to change here to v0.3.2
| echo "Installing Iter8" | ||
| curl -s https://raw.githubusercontent.com/iter8-tools/iter8-install/main/install.sh | bash | ||
| echo "Installing Iter8 with Knative support" | ||
| curl -s https://raw.githubusercontent.com/${GIT_ACCOUNT}/iter8-install/${TAG}/install.sh | bash |
There was a problem hiding this comment.
${TAG} needs to be replaced with main
There was a problem hiding this comment.
@sriumcp I don't understand why this is the case. Why do we not want to install a particular version that the sample was written/tested against?
There was a problem hiding this comment.
What we want to ensure is that a specific version of iter8 corresponds to a specific version of iter8-install (and iter8ctl).
Once you pin the version of iter8-install, by extension, you also pin the version of handler, etc3 and iter8-analytics.
If each tutorial points to a different version of iter8-install, then we will pretty soon be staring at an unmanageable mess in terms of dependencies.
There was a problem hiding this comment.
Re: testing, we do want to test the samples against the iter8-install version that install.md points to.
If the tutorials break for the version installed by install.md, we have a problem, and shouldn't be merging in the first place.
There was a problem hiding this comment.
ok. I think I follow the expected behavior. I have undone most of the changes in this script.
| echo "Installing Iter8's Prometheus add-on" | ||
| curl -s https://raw.githubusercontent.com/iter8-tools/iter8-install/main/install-prom-add-on.sh | bash | ||
| curl -s https://raw.githubusercontent.com/${GIT_ACCOUNT}/iter8-install/${TAG}/install-prom-add-on.sh | bash |
| # Step 6: Install Iter8's Prometheus add-on | ||
| # Step 6: Install sample metrics for Knative and Iter8's Prometheus add-on | ||
| echo "Installing sample metrics" | ||
| kubectl apply -f https://raw.githubusercontent.com/${GIT_ACCOUNT}/iter8-install/${TAG}/metrics/build.yaml |
| @@ -26,7 +26,7 @@ curl -s https://raw.githubusercontent.com/iter8-tools/iter8-install/main/install | |||
| set -e | |||
There was a problem hiding this comment.
@kalantar If you agree, I am in favor of removing the ??? info "Look inside install.sh" tooltip altogether in install.md. It is more work for us in terms of ensuring consistency/correctness of the documentation
| @@ -56,7 +56,7 @@ curl -s https://raw.githubusercontent.com/iter8-tools/iter8-install/main/install | |||
| set -e | |||
There was a problem hiding this comment.
@kalantar If you agree, I am in favor of removing the ??? info "Look inside instal-prom-add-on.sh" tooltip altogether in install.md. It is more work for us in terms of ensuring consistency/correctness of the documentation. Of course, folks can navigate to the GitHub page and look inside!
| --- | ||
| # Helm v3 uses secrets to store Helm release information. | ||
| # | ||
| # By default, when Helm is used within Iter8 experiments, secrets |
| # Helm v3 uses secrets to store Helm release information. | ||
| # | ||
| # By default, when Helm is used within Iter8 experiments, secrets | ||
| # will be located in the Iter8 namespace. |
| # By default, when Helm is used within Iter8 experiments, secrets | ||
| # will be located in the Iter8 namespace. | ||
| # | ||
| # This role binding enables Iter8 handler to read |
| # will be located in the Iter8 namespace. | ||
| # | ||
| # This role binding enables Iter8 handler to write | ||
| # secrets in the namespace where Iter8 is installed |
| @@ -98,7 +106,7 @@ sed "s+URL_VALUE+${URL_VALUE}+g" $ITER8/samples/knative/canaryprogressive/fortio | |||
| restartPolicy: Never | |||
| ``` | |||
|
|
|||
| ## 3. Create Iter8 experiment | |||
| ## 4. Create Iter8 experiment | |||
There was a problem hiding this comment.
When you look inside the Iter8-experiment, it still says --namespace=iter8-system. The new experiment should be copied in here...
| ```shell | ||
| kubectl delete -f $ITER8/samples/knative/canaryprogressive/experiment.yaml | ||
| kubectl delete -f $ITER8/samples/knative/canaryprogressive/fortio.yaml | ||
| helm uninstall sample-app --namespace=iter8-system | ||
| helm uninstall sample-app --namespace=default | ||
| ``` | ||
|
|
||
| ???+ info "Understanding what happened" |
There was a problem hiding this comment.
Understanding what happened also needs to change -- iter8-system must become default
