Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature Request] Update knative canary with progressive rollout instructions to explicitly install RBAC rules for helm #624

Closed
kalantar opened this issue Apr 19, 2021 · 0 comments · Fixed by #625
Labels
kind/enhancement New feature or request

Comments

@kalantar
Copy link
Member

Is your feature request related to a problem? Please describe.
Helm RBAC rules are currently installed as part of Iter8 install. However, they aren't needed for Iter8, only for particular use cases. Remove from Iter8 install and make part of the tutorial instead.

Why is the feature useful for Iter8 users?
This reduces the set of RBAC rules created for a basic Iter8 install.

Describe the solution you'd like
Described above.

Describe alternatives you've considered
None.

Does this issue require a design doc/discussion? If there is a link to the design document/discussions, please provide it below.
You can use this issue thread, or a discussion thread in this repo, for design discussions. If you do so, please provide a link to the specific issue/discussion comment(s) that describes the design.

How will this feature be tested?
[ ] Tutorial still works. Test case for it works as well.

How will this feature be documented?
[ ] update tutorial

@kalantar kalantar added the kind/enhancement New feature or request label Apr 19, 2021
@kalantar kalantar mentioned this issue Apr 19, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant