Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Various changes #1622

Merged
merged 15 commits into from
Sep 7, 2023
+429 −2,912
Merged

Various changes #1622

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
15 commits
Select commit Hold shift + click to select a range
821b834
Various changes
Alan-Cha Sep 5, 2023
5d90474
Remove extraneous function
Alan-Cha Sep 6, 2023
c144976
Bump chart version
Alan-Cha Sep 6, 2023
8af002c
Add test
Alan-Cha Sep 6, 2023
8bac23e
Bump golang version
Alan-Cha Sep 6, 2023
663389c
Update CONTRIBUTING and README
Alan-Cha Sep 6, 2023
c0c8b66
Update CONTRIBUTING
Alan-Cha Sep 6, 2023
c6edadf
Fix typo
Alan-Cha Sep 6, 2023
ff89900
Respond to Michael's comments
Alan-Cha Sep 6, 2023
ab4c467
Fix test
Alan-Cha Sep 6, 2023
d64a5fc
Add tests
Alan-Cha Sep 6, 2023
58b6238
Fix workflow tests
Alan-Cha Sep 7, 2023
7bce3b9
Fix workflows
Alan-Cha Sep 7, 2023
83b6527
Fix workflows
Alan-Cha Sep 7, 2023
42eaba3
Update kubectl log
Alan-Cha Sep 7, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
78 changes: 30 additions & 48 deletions .github/workflows/testcharts.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -45,7 +45,7 @@ jobs:
# TODO: add check to verify when a change is made to kustomize, a similar change is made to charts

http-experiment:
name: HTTP load test
name: HTTP performance test
needs: get_versions
runs-on: ubuntu-latest
strategy:
Expand Down Expand Up @@ -85,14 +85,11 @@ jobs:
- name: Start performance test
if: steps.modified-files.outputs.any_modified == 'true'
run: |
helm upgrade --install \
--repo https://iter8-tools.github.io/iter8 --version 0.16 httpbin-test iter8 \
--localChart \
--chartName charts/iter8 \
helm upgrade --install httpbin-test charts/iter8 \
--set "tasks={http}" \
--set http.url="http://httpbin.default/get" \
--set logLevel=trace
kubectl wait --for=condition=complete --timeout=180s job/default-1-job
kubectl wait --for=condition=complete --timeout=180s job/httpbin-test-1-job

- name: Get Kubernetes status
if: steps.modified-files.outputs.any_modified == 'true'
Expand All @@ -102,7 +99,7 @@ jobs:
- name: View test logs and delete test
if: steps.modified-files.outputs.any_modified == 'true'
run: |
kubectl logs -l iter8.tools/group=httpbin-test
kubectl logs -l iter8.tools/test=httpbin-test
helm delete httpbin-test

- name: Expose metrics service
Expand All @@ -113,10 +110,10 @@ jobs:
- name: Check GET /httpDashboard
if: steps.modified-files.outputs.any_modified == 'true'
run: |
curl "http://localhost:8080/httpDashboard?namespace=default&experiment=default" -f
curl "http://localhost:8080/httpDashboard?namespace=default&experiment=httpbin-test" -f

http-payload-experiment:
name: HTTP load test with payload
name: HTTP performance test with payload
needs: get_versions
runs-on: ubuntu-latest
strategy:
Expand Down Expand Up @@ -156,15 +153,12 @@ jobs:
- name: Start performance test
if: steps.modified-files.outputs.any_modified == 'true'
run: |
helm upgrade --install \
--repo https://iter8-tools.github.io/iter8 --version 0.16 httpbin-test iter8 \
--localChart \
--chartName charts/iter8 \
helm upgrade --install httpbin-test charts/iter8 \
--set "tasks={http}" \
--set http.url="http://httpbin.default/post" \
--set http.payloadStr=hello \
--set logLevel=trace
kubectl wait --for=condition=complete --timeout=180s job/default-1-job
kubectl wait --for=condition=complete --timeout=180s job/httpbin-test-1-job

- name: Get Kubernetes status
if: steps.modified-files.outputs.any_modified == 'true'
Expand All @@ -174,7 +168,7 @@ jobs:
- name: View test logs and delete test
if: steps.modified-files.outputs.any_modified == 'true'
run: |
kubectl logs -l iter8.tools/group=httpbin-test
kubectl logs -l iter8.tools/test=httpbin-test
helm delete httpbin-test

- name: Expose metrics service
Expand All @@ -185,10 +179,10 @@ jobs:
- name: Check GET /httpDashboard
if: steps.modified-files.outputs.any_modified == 'true'
run: |
curl "http://localhost:8080/httpDashboard?namespace=default&experiment=default" -f
curl "http://localhost:8080/httpDashboard?namespace=default&experiment=httpbin-test" -f

http-multiple-experiment:
name: HTTP load test with multiple endpoints
name: HTTP performance test with multiple endpoints
needs: get_versions
runs-on: ubuntu-latest
strategy:
Expand Down Expand Up @@ -228,17 +222,14 @@ jobs:
- name: Start performance test
if: steps.modified-files.outputs.any_modified == 'true'
run: |
helm upgrade --install \
--repo https://iter8-tools.github.io/iter8 --version 0.16 httpbin-test iter8 \
--localChart \
--chartName charts/iter8 \
helm upgrade --install httpbin-test charts/iter8 \
--set "tasks={http}" \
--set http.endpoints.get.url=http://httpbin.default/get \
--set http.endpoints.getAnything.url=http://httpbin.default/anything \
--set http.endpoints.post.url=http://httpbin.default/post \
--set http.endpoints.post.payloadStr=hello \
--set logLevel=trace
kubectl wait --for=condition=complete --timeout=180s job/default-1-job
kubectl wait --for=condition=complete --timeout=180s job/httpbin-test-1-job

- name: Get Kubernetes status
if: steps.modified-files.outputs.any_modified == 'true'
Expand All @@ -248,7 +239,7 @@ jobs:
- name: View test logs and delete test
if: steps.modified-files.outputs.any_modified == 'true'
run: |
kubectl logs -l iter8.tools/group=httpbin-test
kubectl logs -l iter8.tools/test=httpbin-test
helm delete httpbin-test

- name: Expose metrics service
Expand All @@ -259,10 +250,10 @@ jobs:
- name: Check GET /httpDashboard
if: steps.modified-files.outputs.any_modified == 'true'
run: |
curl "http://localhost:8080/httpDashboard?namespace=default&experiment=default" -f
curl "http://localhost:8080/httpDashboard?namespace=default&experiment=httpbin-test" -f

grpc-experiment:
name: gRPC load test
name: gRPC performance test
needs: get_versions
runs-on: ubuntu-latest
strategy:
Expand Down Expand Up @@ -311,10 +302,7 @@ jobs:
- name: Start performance test
if: steps.modified-files.outputs.any_modified == 'true'
run: |
helm upgrade --install \
--repo https://iter8-tools.github.io/iter8 --version 0.16 routeguide-test iter8 \
--localChart \
--chartName charts/iter8 \
helm upgrade --install routeguide-test charts/iter8 \
--set "tasks={ready,grpc}" \
--set ready.deploy=routeguide \
--set ready.service=routeguide \
Expand All @@ -324,7 +312,7 @@ jobs:
--set grpc.call=routeguide.RouteGuide.GetFeature \
--set grpc.dataURL=https://raw.githubusercontent.com/iter8-tools/docs/v0.13.13/samples/grpc-payload/unary.json \
--set logLevel=trace
kubectl wait --for=condition=complete --timeout=180s job/default-1-job
kubectl wait --for=condition=complete --timeout=180s job/routeguide-test-1-job

- name: Get Kubernetes status
if: steps.modified-files.outputs.any_modified == 'true'
Expand All @@ -334,7 +322,7 @@ jobs:
- name: View test logs and delete test
if: steps.modified-files.outputs.any_modified == 'true'
run: |
kubectl logs -l iter8.tools/group=routeguide-test
kubectl logs -l iter8.tools/test=routeguide-test
helm delete routeguide-test

- name: Expose metrics service
Expand All @@ -345,10 +333,10 @@ jobs:
- name: Check GET /grpcDashboard
if: steps.modified-files.outputs.any_modified == 'true'
run: |
curl "http://localhost:8080/grpcDashboard?namespace=default&experiment=default" -f
curl "http://localhost:8080/grpcDashboard?namespace=default&experiment=routeguide-test" -f

grpc-multiple-experiment:
name: gRPC load test with multiple endpoints
name: gRPC performance test with multiple endpoints
needs: get_versions
runs-on: ubuntu-latest
strategy:
Expand Down Expand Up @@ -397,10 +385,7 @@ jobs:
- name: Start performance test
if: steps.modified-files.outputs.any_modified == 'true'
run: |
helm upgrade --install \
--repo https://iter8-tools.github.io/iter8 --version 0.16 routeguide-test iter8 \
--localChart \
--chartName charts/iter8 \
helm upgrade --install routeguide-test charts/iter8 \
--set "tasks={ready,grpc}" \
--set ready.deploy=routeguide \
--set ready.service=routeguide \
Expand All @@ -412,7 +397,7 @@ jobs:
--set grpc.endpoints.listFeatures.call=routeguide.RouteGuide.ListFeatures \
--set grpc.endpoints.listFeatures.dataURL=https://raw.githubusercontent.com/iter8-tools/docs/v0.13.13/samples/grpc-payload/server.json \
--set logLevel=trace
kubectl wait --for=condition=complete --timeout=180s job/default-1-job
kubectl wait --for=condition=complete --timeout=180s job/routeguide-test-1-job

- name: Get Kubernetes status
if: steps.modified-files.outputs.any_modified == 'true'
Expand All @@ -422,7 +407,7 @@ jobs:
- name: View test logs and delete test
if: steps.modified-files.outputs.any_modified == 'true'
run: |
kubectl logs -l iter8.tools/group=routeguide-test
kubectl logs -l iter8.tools/test=routeguide-test
helm delete routeguide-test

- name: Expose metrics service
Expand All @@ -433,10 +418,10 @@ jobs:
- name: Check GET /grpcDashboard
if: steps.modified-files.outputs.any_modified == 'true'
run: |
curl "http://localhost:8080/grpcDashboard?namespace=default&experiment=default" -f
curl "http://localhost:8080/grpcDashboard?namespace=default&experiment=routeguide-test" -f

grpc-experiment2:
name: gRPC load test 2
name: gRPC performance test 2
needs: get_versions
runs-on: ubuntu-latest
strategy:
Expand Down Expand Up @@ -476,16 +461,13 @@ jobs:
- name: Start performance test
if: steps.modified-files.outputs.any_modified == 'true'
run: |
helm upgrade --install \
--repo https://iter8-tools.github.io/iter8 --version 0.16 hello-test iter8 \
--localChart \
--chartName charts/iter8 \
helm upgrade --install hello-test charts/iter8 \
--set "tasks={grpc}" \
--set grpc.host="hello.default:50051" \
--set grpc.call="helloworld.Greeter.SayHello" \
--set grpc.protoURL="https://raw.githubusercontent.com/grpc/grpc-go/master/examples/helloworld/helloworld/helloworld.proto" \
--set logLevel=trace
kubectl wait --for=condition=complete --timeout=180s job/default-1-job
kubectl wait --for=condition=complete --timeout=180s job/hello-test-1-job

- name: Get Kubernetes status
if: steps.modified-files.outputs.any_modified == 'true'
Expand All @@ -495,7 +477,7 @@ jobs:
- name: View test logs and delete test
if: steps.modified-files.outputs.any_modified == 'true'
run: |
kubectl logs -l iter8.tools/group=hello-test
kubectl logs -l iter8.tools/test=hello-test
helm delete hello-test

- name: Expose metrics service
Expand All @@ -506,4 +488,4 @@ jobs:
- name: Check GET /grpcDashboard
if: steps.modified-files.outputs.any_modified == 'true'
run: |
curl "http://localhost:8080/grpcDashboard?namespace=default&experiment=default" -f
curl "http://localhost:8080/grpcDashboard?namespace=default&experiment=hello-test" -f
28 changes: 14 additions & 14 deletions .github/workflows/verifyuserexperience.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,7 @@ on:

jobs:
http-experiment:
name: HTTP load test
name: HTTP performance test
runs-on: ubuntu-latest

steps:
Expand Down Expand Up @@ -48,7 +48,7 @@ jobs:

- name: View test logs and delete test
run: |
kubectl logs -l iter8.tools/group=httpbin-test
kubectl logs -l iter8.tools/test=httpbin-test
helm delete httpbin-test

- name: Expose metrics service
Expand All @@ -60,7 +60,7 @@ jobs:
curl "http://localhost:8080/httpDashboard?namespace=default&experiment=default" -f

http-payload-experiment:
name: HTTP load test with payload
name: HTTP performance test with payload
runs-on: ubuntu-latest

steps:
Expand Down Expand Up @@ -96,7 +96,7 @@ jobs:

- name: View test logs and delete test
run: |
kubectl logs -l iter8.tools/group=httpbin-test
kubectl logs -l iter8.tools/test=httpbin-test
helm delete httpbin-test


Expand All @@ -109,7 +109,7 @@ jobs:
curl "http://localhost:8080/httpDashboard?namespace=default&experiment=default" -f

http-multiple-experiment:
name: HTTP load test with multiple endpoints
name: HTTP performance test with multiple endpoints
runs-on: ubuntu-latest

steps:
Expand Down Expand Up @@ -146,7 +146,7 @@ jobs:

- name: View test logs and delete test
run: |
kubectl logs -l iter8.tools/group=httpbin-test
kubectl logs -l iter8.tools/test=httpbin-test
helm delete httpbin-test

- name: Expose metrics service
Expand All @@ -158,7 +158,7 @@ jobs:
curl "http://localhost:8080/httpDashboard?namespace=default&experiment=default" -f

grpc-experiment:
name: gRPC load test
name: gRPC performance test
runs-on: ubuntu-latest

steps:
Expand Down Expand Up @@ -207,7 +207,7 @@ jobs:

- name: View test logs and delete test
run: |
kubectl logs -l iter8.tools/group=routeguide-test
kubectl logs -l iter8.tools/test=routeguide-test
helm delete routeguide-test

- name: Expose metrics service
Expand All @@ -219,7 +219,7 @@ jobs:
curl "http://localhost:8080/grpcDashboard?namespace=default&experiment=default" -f

grpc-multiple-experiment:
name: gRPC load test with multiple endpoints
name: gRPC performance test with multiple endpoints
runs-on: ubuntu-latest

steps:
Expand Down Expand Up @@ -270,7 +270,7 @@ jobs:

- name: View test logs and delete test
run: |
kubectl logs -l iter8.tools/group=routeguide-test
kubectl logs -l iter8.tools/test=routeguide-test
helm delete routeguide-test

- name: Expose metrics service
Expand All @@ -282,7 +282,7 @@ jobs:
curl "http://localhost:8080/grpcDashboard?namespace=default&experiment=default" -f

grpc-experiment2:
name: gRPC load test 2
name: gRPC performance test 2
runs-on: ubuntu-latest

steps:
Expand Down Expand Up @@ -319,7 +319,7 @@ jobs:

- name: View test logs and delete test
run: |
kubectl logs -l iter8.tools/group=hello-test
kubectl logs -l iter8.tools/test=hello-test
helm delete hello-test

- name: Expose metrics service
Expand Down Expand Up @@ -370,7 +370,7 @@ jobs:

- name: View test logs and delete test
run: |
kubectl logs -l iter8.tools/group=httpbin-test
kubectl logs -l iter8.tools/test=httpbin-test
helm delete httpbin-test

- name: Expose metrics service
Expand Down Expand Up @@ -427,7 +427,7 @@ jobs:

- name: View test logs and delete test
run: |
kubectl logs -l iter8.tools/group=httpbin-test
kubectl logs -l iter8.tools/test=httpbin-test
helm delete httpbin-test

- name: Expose metrics service
Expand Down
4 changes: 2 additions & 2 deletions CONTRIBUTING.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,7 @@ If anything doesn't make sense, or doesn't work when you run it, please open a b

We welcome many types of contributions including:

* [CLI and Iter8 experiment charts](#iter8-toolsiter8)
* [CLI and Iter8 performance test charts](#iter8-toolsiter8)
* [Docs](#iter8-toolsdocs)
* CI, builds, and tests
* Reviewing pull requests
Expand Down Expand Up @@ -71,7 +71,7 @@ repository, you can amend your commit with the sign-off by running:

The Iter8 project consists of the following repos.

1. [iter8-tools/iter8](https://github.com/iter8-tools/iter8): source for the Iter8 CLI, experiment, and controller charts
1. [iter8-tools/iter8](https://github.com/iter8-tools/iter8): source for the Iter8 CLI, performance test, and controller charts
2. [iter8-tools/docs](https://github.com/iter8-tools/docs): source for Iter8 docs

### iter8-tools/iter8
Expand Down
Loading