Various changes #1622
Merged
Various changes #1622
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Alan-Cha
force-pushed
the
v16-touchup
branch
from
985f014 to
4aadf36
Compare
Alan-Cha
commented
Sep 6, 2023
Alan-Cha
force-pushed
the
v16-touchup
branch
from
a27c0d0 to
4aadf36
Compare
kalantar
reviewed
Sep 6, 2023
cmd/krun.go
Outdated
|
|
||
| $ iter8 k run --namespace {{ .Experiment.Namespace }} --group {{ .Experiment.group }} | ||
| $ iter8 k run --namespace {{ .Test.Namespace }} --group {{ .Test.group }} |
There was a problem hiding this comment.
also change _k-job.tpl to remove this option
Signed-off-by: Alan Cha <[email protected]>
Signed-off-by: Alan Cha <[email protected]>
Signed-off-by: Alan Cha <[email protected]>
Signed-off-by: Alan Cha <[email protected]>
Signed-off-by: Alan Cha <[email protected]>
Signed-off-by: Alan Cha <[email protected]>
Signed-off-by: Alan Cha <[email protected]>
Signed-off-by: Alan Cha <[email protected]>
Signed-off-by: Alan Cha <[email protected]>
Signed-off-by: Alan Cha <[email protected]>
Signed-off-by: Alan Cha <[email protected]>
Alan-Cha
force-pushed
the
v16-touchup
branch
from
b97f883 to
d64a5fc
Compare
Alan-Cha
commented
Sep 6, 2023
Comment on lines
-84
to
-107
| // errorCode checks if a given code is an error code | ||
| func (t *collectHTTPTask) errorCode(code int) bool { | ||
| // connection failure | ||
| if code == -1 { | ||
| return true | ||
| } | ||
| // HTTP errors | ||
| for _, lims := range t.With.ErrorRanges { | ||
| // if no lower limit (check upper) | ||
| if lims.Lower == nil && code <= *lims.Upper { | ||
| return true | ||
| } | ||
| // if no upper limit (check lower) | ||
| if lims.Upper == nil && code >= *lims.Lower { | ||
| return true | ||
| } | ||
| // if both limits are present (check both) | ||
| if lims.Upper != nil && lims.Lower != nil && code <= *lims.Upper && code >= *lims.Lower { | ||
| return true | ||
| } | ||
| } | ||
| return false | ||
| } | ||
|
|
Signed-off-by: Alan Cha <[email protected]>
Signed-off-by: Alan Cha <[email protected]>
Signed-off-by: Alan Cha <[email protected]>
Signed-off-by: Alan Cha <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #1598
Fix #1615
Fix #1611
Fix #1617
Fix #1492