Capture context when creating a generator function, not when it is first .send to.
#474
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When eliot switched to context vars in itamarst#397, this exception became unused. Since it was never public, there is no reason to keep it around.
tomprince
force-pushed
the
eliot-generator-context
branch
from
ca4e172
to
9f5b201
Compare
|
@exarkun could you take a look? This makes sense to me, but you understand this code better. Or did at one point 😁 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adjust
eliot_friendly_generator_functionto handle the use case of #472 but doesn't do the work of exposing it to users.