-
Notifications
You must be signed in to change notification settings - Fork 66
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Switch to using contextvars, in order to support Trio #397
Conversation
…outine, but that's... reasonable.
This is broken. I need to switch to using just ContextVar.set/get, without managing our own stack; the latter is no longer necessary. And tests to demonstrate the problems I saw with Trio example. |
Should in theory work now, modulo minor fixes. |
@jtrakk would appreciate some testing, if you have the time. |
I'm not sure what's supposed to happen if I continue an action in a subprocess (
|
Could you share a minimal reproducer? Thanks! |
The issue was due to my broken dual-purpose logging decorator implementation. I'll keep poking around and will update if I experience problems. |
Switch to using contextvars, in order to support Trio.
When eliot switched to context vars in itamarst#397, this exception became unused. Since it was never public, there is no reason to keep it around.
When eliot switched to context vars in itamarst#397, this exception became unused. Since it was never public, there is no reason to keep it around.
Fixes #290
Fixes #396