Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#228 rm input empty string default value #705

Merged
merged 2 commits into from
Sep 18, 2023

Conversation

simonhir
Copy link
Member

Description

Remove input empty string default values.

Reference

Issues #228

@codecov
Copy link

codecov bot commented Sep 15, 2023

Codecov Report

Merging #705 (005f93a) into dev (da98e77) will increase coverage by 0.00%.
The diff coverage is 0.00%.

@@            Coverage Diff            @@
##                dev     #705   +/-   ##
=========================================
  Coverage     22.69%   22.70%           
  Complexity      893      893           
=========================================
  Files           602      602           
  Lines          9963     9959    -4     
  Branches        678      678           
=========================================
  Hits           2261     2261           
+ Misses         7577     7573    -4     
  Partials        125      125           
Flag Coverage Δ
unittests 22.70% <0.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Changed Coverage Δ
...n/domain/service/ServiceDefinitionDataService.java 0.00% <0.00%> (ø)
...dapter/out/schema/JsonSchemaValidationAdapter.java 25.00% <0.00%> (+5.00%) ⬆️

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@simonhir simonhir merged commit d4e0af7 into dev Sep 18, 2023
4 of 5 checks passed
@simonhir simonhir deleted the feat/#228-rm-input-empty-string-init branch September 18, 2023 06:00
simonhir added a commit that referenced this pull request Oct 12, 2023
simonhir added a commit that referenced this pull request Oct 12, 2023
simonhir added a commit that referenced this pull request Oct 12, 2023
simonhir added a commit that referenced this pull request Oct 24, 2023
* bugfix(#771): harden the ou tree ldap search (#814)

* bugfix: harden the ou tree ldap search

* bugfix: harden the ou tree ldap search

---------

Co-authored-by: Lukas Mösle <[email protected]>

* chore: bump release version (#816)

* chore: mvn auto version bump to 1.1.1-SNAPSHOT

* v1.1.1

---------

Co-authored-by: DigiWF Github Bot <[email protected]>

* #817 fix instances page missing col state (#818)

* chore: bump release version (#819)

* chore: mvn auto version bump to 1.1.2-SNAPSHOT

* v1.1.2

---------

Co-authored-by: DigiWF Github Bot <[email protected]>

* Revert "#228 rm input empty string default value (#705)" (#837)

This reverts commit d4e0af7.

* chore: bump release version (#838)

* chore: mvn auto version bump to 1.1.3-SNAPSHOT

* v1.1.3

---------

Co-authored-by: DigiWF Github Bot <[email protected]>

---------

Co-authored-by: Lukas Mösle <[email protected]>
Co-authored-by: Lukas Mösle <[email protected]>
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Co-authored-by: DigiWF Github Bot <[email protected]>
simonhir added a commit that referenced this pull request Dec 8, 2023
simonhir added a commit that referenced this pull request Dec 8, 2023
simonhir added a commit that referenced this pull request Dec 8, 2023
simonhir added a commit that referenced this pull request Dec 11, 2023
simonhir added a commit that referenced this pull request Dec 11, 2023
simonhir added a commit that referenced this pull request Dec 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants