Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "Revert "#228 rm input empty string default value (#705)" (#837)" #1090

Merged
merged 1 commit into from
Dec 8, 2023

Conversation

simonhir
Copy link
Member

@simonhir simonhir commented Dec 8, 2023

Description

Remove input var initialization with empty string.

Reference

Issues: closes #228

Copy link

codecov bot commented Dec 8, 2023

Codecov Report

Attention: 2 lines in your changes are missing coverage. Please review.

Comparison is base (1e44458) 37.64% compared to head (e94be7c) 37.65%.
Report is 1 commits behind head on release/2023-december.

Files Patch % Lines
...n/domain/service/ServiceDefinitionDataService.java 0.00% 1 Missing ⚠️
...dapter/out/schema/JsonSchemaValidationAdapter.java 0.00% 1 Missing ⚠️
Additional details and impacted files
@@                     Coverage Diff                     @@
##             release/2023-december    #1090      +/-   ##
===========================================================
+ Coverage                    37.64%   37.65%   +0.01%     
  Complexity                    1258     1258              
===========================================================
  Files                          601      601              
  Lines                         8703     8699       -4     
  Branches                       422      422              
===========================================================
  Hits                          3276     3276              
+ Misses                        5294     5290       -4     
  Partials                       133      133              
Flag Coverage Δ
unittests 37.65% <0.00%> (+0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@darenegade darenegade left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Definition von Wahnsinn: Man macht das Gleiche und erwartet ein anderes Ergebnis

Na mal schauen....passt

@simonhir simonhir merged commit ccc4921 into release/2023-december Dec 8, 2023
7 of 8 checks passed
@simonhir simonhir deleted the feature/readd-rm-input-init branch December 8, 2023 09:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants