Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert MixerClient stats #961

Merged
merged 3 commits into from
Jan 30, 2018
Merged

Conversation

JimmyCYJ
Copy link
Member

@JimmyCYJ JimmyCYJ commented Jan 30, 2018

This reverts commit 8d2fc52.

What this PR does / why we need it: Due to segmentation fault issue #2906, temporarily revert Mixer stats. There are three commits to be reverted.

Which issue this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close that issue when PR gets merged): fixes #

Special notes for your reviewer:

Release note:

@googlebot googlebot added the cla: yes Set by the Google CLA bot to indicate the author of a PR has signed the Google CLA. label Jan 30, 2018
@qiwzhang
Copy link
Contributor

/lgtm
/approve

@istio-merge-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: qiwzhang

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these OWNERS Files:

You can indicate your approval by writing /approve in a comment
You can cancel your approval by writing /approve cancel in a comment

@JimmyCYJ JimmyCYJ changed the title Revert "Fix time interval setup. (#954)" Revert Mixer stats Jan 30, 2018
@qiwzhang qiwzhang changed the title Revert Mixer stats Revert MixerClient stats Jan 30, 2018
@istio-merge-robot
Copy link

/test all [submit-queue is verifying that this PR is safe to merge]

@istio-merge-robot
Copy link

Automatic merge from submit-queue.

@istio-merge-robot istio-merge-robot merged commit 4d32832 into istio:master Jan 30, 2018
@JimmyCYJ JimmyCYJ deleted the revert-mixer-stats branch January 30, 2018 23:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla: yes Set by the Google CLA bot to indicate the author of a PR has signed the Google CLA.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants