Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix time interval setup. #954

Merged
merged 4 commits into from
Jan 30, 2018

Conversation

JimmyCYJ
Copy link
Member

What this PR does / why we need it: Before this change, we always set stats update interval to 10s inside MixerStatsObject::OnTimer(). This PR uses configured stats interval if that interval is larger than zero.

Which issue this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close that issue when PR gets merged): fixes #

Special notes for your reviewer:

Release note:

NONE

@googlebot googlebot added the cla: yes Set by the Google CLA bot to indicate the author of a PR has signed the Google CLA. label Jan 29, 2018
@JimmyCYJ
Copy link
Member Author

/retest

@istio istio deleted a comment from istio-testing Jan 29, 2018
@qiwzhang
Copy link
Contributor

/approve

@JimmyCYJ
Copy link
Member Author

/test proxy-presubmit

@qiwzhang
Copy link
Contributor

/lgtm

@qiwzhang
Copy link
Contributor

/approve

@istio-merge-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: qiwzhang

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these OWNERS Files:

You can indicate your approval by writing /approve in a comment
You can cancel your approval by writing /approve cancel in a comment

@istio-merge-robot
Copy link

/test all [submit-queue is verifying that this PR is safe to merge]

@istio-merge-robot
Copy link

Automatic merge from submit-queue.

@istio-merge-robot istio-merge-robot merged commit 8d2fc52 into istio:master Jan 30, 2018
@JimmyCYJ JimmyCYJ deleted the fix-stats-update-interval branch January 30, 2018 18:29
JimmyCYJ added a commit to JimmyCYJ/proxy that referenced this pull request Jan 30, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla: yes Set by the Google CLA bot to indicate the author of a PR has signed the Google CLA.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants