BREAKING CHANGE: Include collection pages in the Pages tab
#64
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
THIS WILL ONLY WORK WITH THE BACKEND BRANCH `feat/flatten-collection-into-pages`. This commit now introduces a new settings modal to handle CRUD operations for collection pages and displays collection pages in the `Pages` tab.
Since collection pages are shown on the `pages` tab, there is no need for a separate `Collections` tab to show the various collection pages.
For context, when the user clicks on the collection page under the `collections/:collectionName` endpoint, its sibling collection pages gets passed into `location` of the router. The `EditCollectionPage` then retrieves those pages and renders them in the leftnav of the preview. Since we are flattening the collections tab into the pages tab, we currently do not keep track of the sibling collection pages of any collection page. Hence this commit moves the logic to find the sibling collection pages into `EditCollectionPage`.
taufiq
changed the title
Pages tabPages tab
taufiq
changed the title
Pages tabPages tab
|
This PR also resolves issue #19 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR does the following:
Collectionstab and displays the displaced collection pages in thePagestab insteadCollectionPagesSettingsModal)/sites/:siteName/collections/:collectionName/:pageNameendpoint instead of the default/sites/:siteName/pages/:pageNameendpoint.NOTE
This is a pull request that needs to be merged along with the PR for the backend or else it will break.