BREAKING CHANGE: Include collection pages in the GET pages endpoint
#31
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
THIS IS FOR THE FRONTEND BRANCH `feat/flatten-collection-into-pages`. This commit will include collection pages and tokenize the items shown in the `GET pages` endpoint into types `simple-page` and `collection`.
This commit adds in comments to explain how the logic in `GET pages` endpoint works.
routes/pages.js
Outdated
| const CollectionPage = new File(access_token, siteName) | ||
| const collectionPageType = new CollectionPageType(collectionName) | ||
| CollectionPage.setFileType(collectionPageType) | ||
| const collectionPages = await Bluebird.map(await CollectionPage.list(), (item) => { |
There was a problem hiding this comment.
You don't need to use await Bluebird.map here. A simple map over the result of await CollectionPage.list() works because there is no async call within the map.
There was a problem hiding this comment.
The PR looks good otherwise
There was a problem hiding this comment.
ohhh yeah good point alright will fix that
There was no need to call `Bluebird.map` with a promise that has been resolved (`await CollectionPage.list()`)
harishv7
pushed a commit
that referenced
this pull request
Feb 17, 2023
…#31) * feat!: include collection pages in pages endpoint THIS IS FOR THE FRONTEND BRANCH `feat/flatten-collection-into-pages`. This commit will include collection pages and tokenize the items shown in the `GET pages` endpoint into types `simple-page` and `collection`. * style: add comments on `GET pages` endpoint This commit adds in comments to explain how the logic in `GET pages` endpoint works. * refactor(pages): remove redundant Bluebird map There was no need to call `Bluebird.map` with a promise that has been resolved (`await CollectionPage.list()`)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR now shows all collection pages, along with the existing simple pages on the
GET pagesendpoint.Context
Initially only simple pages were shown in the
GET pagesendpoint. The team decided that collection pages would be included as well as we were scraping the 'Collections' tab in the frontend.Implications
This pull request needs to be merged into
masteralong with the frontend PR or else the frontend will break.