Feat/misc ui fixes #258
Merged
Feat/misc ui fixes #258
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 5 commits
November 24, 2020 16:51
This commit adds a loading text to the Sites layout as a form of feedback to the user.
Currently on the Resources layout, if the api call to retrieve resource room name and resource categories fail, then the page continues to display loading text, which is misleading to users as they'll continue waiting for a result. This commit fixes that by setting the load state to be false if there is an error in the API call.
Similar to the the Resources layout, if the api call to retrieve collections fails, the page continues to display misleading loading text This commit fixes that by setting the load state to be false if there is an error in the API call.
This was
linked to
issues
Nov 24, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR resolves the following 3 minor UI/UX issues:
Siteslayout