Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Do not display loading text if pages/resources do not exist #141

Closed
kwajiehao opened this issue Oct 7, 2020 · 0 comments · Fixed by #258
Closed

Do not display loading text if pages/resources do not exist #141

kwajiehao opened this issue Oct 7, 2020 · 0 comments · Fixed by #258
Assignees
Labels
bug Something isn't working P2 Important, but not urgent. Do it when have time.

Comments

@kwajiehao
Copy link
Contributor

Currently, we display a loading text when we're fetching pages or resources. However, even if there are no pages or resources to be found (as with the answerbot repo), the loading text stays on the screen. This is an important issue because we actually have sites without resource rooms (some of the MLAW sites which simply link to the resource room of the main MLAW site).

We can consider using a more understandable text (No resources found), or we might even consider removing the resources button on the left nav of our CMS.

Screenshot 2020-10-07 at 4 20 29 PM

@kwajiehao kwajiehao added bug Something isn't working P2 Important, but not urgent. Do it when have time. labels Oct 7, 2020
@kwajiehao kwajiehao changed the title enhancement: do not display loading text if pages/resources do not exist Do not display loading text if pages/resources do not exist Oct 7, 2020
@kwajiehao kwajiehao self-assigned this Nov 24, 2020
@kwajiehao kwajiehao linked a pull request Nov 24, 2020 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working P2 Important, but not urgent. Do it when have time.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant