-
Notifications
You must be signed in to change notification settings - Fork 10
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: introduce new help overlay for add section button #1515
Merged
Merged
Changes from all commits
Commits
Show all changes
6 commits
Select commit
Hold shift + click to select a range
088032f
chore(editable): promote to shared component
dcshzj 48236e7
feat: introduce new help overlay for add section button
dcshzj f97e496
feat: add storybook for add section button
dcshzj 28d6a23
chore: remove unneeded story parameter
dcshzj 99c33a9
chore: update images for text cards and announcements
dcshzj b688a48
fix: adjust story to be more extendible
dcshzj File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
Large diffs are not rendered by default.
Oops, something went wrong.
Large diffs are not rendered by default.
Oops, something went wrong.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,108 @@ | ||
import { Box, Center } from "@chakra-ui/react" | ||
import type { Meta, StoryFn } from "@storybook/react" | ||
|
||
import { | ||
HomepageAnnouncementsSampleImage, | ||
HomepageTextCardsSampleImage, | ||
} from "assets/images" | ||
|
||
import { AddSectionButton } from "./AddSectionButton" | ||
|
||
const addSectionButtonMeta = { | ||
title: "Components/AddSectionButton", | ||
component: AddSectionButton, | ||
} as Meta<typeof AddSectionButton> | ||
|
||
interface AddSectionButtonOptions { | ||
title: string | ||
subtitle: string | ||
overlayTitle?: string | ||
overlayDescription?: string | ||
overlayImage?: JSX.Element | ||
} | ||
|
||
interface AddSectionButtonTemplateArgs { | ||
buttonText: string | ||
options: AddSectionButtonOptions[] | ||
} | ||
|
||
const Template: StoryFn<AddSectionButtonTemplateArgs> = ({ | ||
buttonText, | ||
options, | ||
}: AddSectionButtonTemplateArgs) => { | ||
return ( | ||
<Box height="50vh" width="450px"> | ||
<Center | ||
height="40vh" | ||
bgColor="brand.secondary.100" | ||
my={3} | ||
borderRadius="0.5rem" | ||
> | ||
This space is for content. | ||
</Center> | ||
<AddSectionButton buttonText={buttonText}> | ||
<AddSectionButton.List> | ||
{options.map((option) => { | ||
if (option.overlayTitle && option.overlayDescription) { | ||
return ( | ||
<AddSectionButton.HelpOverlay | ||
title={option.overlayTitle} | ||
description={option.overlayDescription} | ||
image={option.overlayImage} | ||
> | ||
<AddSectionButton.Option | ||
title={option.title} | ||
subtitle={option.subtitle} | ||
/> | ||
</AddSectionButton.HelpOverlay> | ||
) | ||
} | ||
|
||
return ( | ||
<AddSectionButton.Option | ||
title={option.title} | ||
subtitle={option.subtitle} | ||
/> | ||
) | ||
})} | ||
</AddSectionButton.List> | ||
</AddSectionButton> | ||
</Box> | ||
) | ||
} | ||
|
||
export const Default = Template.bind({}) | ||
Default.args = { | ||
buttonText: "Add section", | ||
options: [ | ||
{ | ||
title: "Infopic", | ||
subtitle: "Add an image and text", | ||
}, | ||
{ | ||
title: "Text cards", | ||
subtitle: "Add up to 4 clickable cards with text", | ||
overlayTitle: "Text cards", | ||
overlayDescription: | ||
"Add clickable cards with bite-sized information to your homepage. You can link any page or external URL, such as blog posts, articles, and more.", | ||
overlayImage: <HomepageTextCardsSampleImage />, | ||
}, | ||
{ | ||
title: "Info-columns", | ||
subtitle: "Add snippets of text in 2- or 3-column layouts", | ||
overlayTitle: "Info-Columns", | ||
overlayDescription: | ||
"Add bite-sized snippets of text in a multi-column layout. These texts aren’t clickable. Perfect for showing informative text that describes your organisation.", | ||
}, | ||
{ | ||
title: "Announcements", | ||
subtitle: "Add a list of announcements with dates", | ||
overlayTitle: "Announcements", | ||
overlayDescription: | ||
"Make exciting news from your organisation stand out by adding a list of announcements with dates on your homepage.", | ||
overlayImage: <HomepageAnnouncementsSampleImage />, | ||
}, | ||
], | ||
} | ||
|
||
export default addSectionButtonMeta |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
File renamed without changes.
File renamed without changes.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey, what are your thoughts on creating an object interface for each card, then passing in an array?
This way we can
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Adjusted in b688a48! I think I got a little carried away here oops.