-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: introduce new help overlay for add section button #1515
Conversation
!run chromatic |
!run chromatic |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Approving since my comments are non-functional.
I do think think the storybook code can be made a lot neater for extensibility in the future
Biz logic wise lgtm
component: AddSectionButton, | ||
} as Meta<typeof AddSectionButton> | ||
|
||
interface AddSectionButtonTemplateArgs { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey, what are your thoughts on creating an object interface for each card, then passing in an array?
This way we can
- easily extend in the future if needed
- less verbose code
- Guarantee each object has the same shape in one glance
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Adjusted in b688a48! I think I got a little carried away here oops.
Problem
The add section button does not have the ability to show a help overlay.
Solution
Breaking Changes
Features:
Before & After Screenshots
BEFORE:
AFTER:
Tests
npm run tests
)!run e2e
)Deploy Notes
None