Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(editable): introduce new nested card variant #1478

Merged
merged 4 commits into from
Sep 6, 2023
Merged

feat(editable): introduce new nested card variant #1478

merged 4 commits into from
Sep 6, 2023

Conversation

dcshzj
Copy link
Contributor

@dcshzj dcshzj commented Sep 6, 2023

Problem

Closes IS-468.

Solution

Breaking Changes

  • Yes - this PR contains breaking changes
  • No - this PR is backwards compatible

Features:

  • A new nested card variant is introduced for the DraggableAccordionItem, which is part of Editable

Figma link is here.

Before & After Screenshots

BEFORE:

Screenshot 2023-09-06 at 4 29 48 PM

AFTER:

Screenshot 2023-09-06 at 4 29 01 PM

Tests

  • Unit tests (using npm run tests)
  • e2e tests (comment on this PR with the text !run e2e)
  • Smoke tests
    • Navigate to the Contact Us page of a site that is using the new contact us stylings
    • Verify that the size of the nested card in Locations > Operating hours is now smaller
    • Verify that the nested card's title font colour is lighter
    • Verify that the nested card's title font colour will become darker on hover
    • Verify that expanding the nested card will have a blue border and blue background
    • Verify that dragging either the nested card or a normal accordion card will have a blue border while dragging
    • Verify that the spacing between nested cards is now smaller

Deploy Notes

None

@dcshzj dcshzj requested a review from a team September 6, 2023 08:36
@seaerchin
Copy link
Contributor

abit chonky already - maybe we might want to consider making this more maintainable if we are going to do work on this in the future.

for now, still acceptable.

@dcshzj dcshzj temporarily deployed to staging September 6, 2023 08:48 — with GitHub Actions Inactive
@dcshzj dcshzj temporarily deployed to staging September 6, 2023 08:50 — with GitHub Actions Inactive
@dcshzj dcshzj force-pushed the IS-468-new-nested-cards branch from 16fcdd0 to 3a8cc6a Compare September 6, 2023 10:10
@dcshzj dcshzj temporarily deployed to staging September 6, 2023 10:23 — with GitHub Actions Inactive
@dcshzj dcshzj merged commit 0385f1b into develop Sep 6, 2023
@mergify mergify bot deleted the IS-468-new-nested-cards branch September 6, 2023 10:29
alexanderleegs pushed a commit that referenced this pull request Sep 7, 2023
@dcshzj @alexanderleegs
feat(editable): introduce new nested card variant (#1478)
410b76e 
* feat(icons): introduce new vertical draggable icon

* feat(editable): introduce nested version of accordion

* fix(contactus): update location card to use nested

* fix: border radius of error divider
alexanderleegs pushed a commit that referenced this pull request Sep 7, 2023
@dcshzj @alexanderleegs
feat(editable): introduce new nested card variant (#1478)
fabf409 
* feat(icons): introduce new vertical draggable icon

* feat(editable): introduce nested version of accordion

* fix(contactus): update location card to use nested

* fix: border radius of error divider
@alexanderleegs alexanderleegs mentioned this pull request Sep 7, 2023
Merged
24 tasks
alexanderleegs added a commit that referenced this pull request Sep 7, 2023
@alexanderleegs @seaerchin @dcshzj
Merge pull request #1480 from isomerpages/release/0.42.0
71474fe 
* feat: re-introduce comment-based trigger for Chromatic (#1468)

* chore(contactus): styling fixes based on design feedback (#1470)

* chore(contactus): styling fixes based on design feedback

* fix: use subhead-1 styling instead

* chore: remove unused import

* Chore/fix edit nav bar styles (#1466)

* fix: nav menu template styles

* fix: add spacing for legacy nav section

* chore: remove unused attributes

* chore: move flex into className

* Chore/fix title text (#1472)

* chore: fix title text

* chore: fix other instances of spacing

* fix(edithomepage): spread properly (#1474)

Co-authored-by: seaerchin <[email protected]>

* Fix/edit nav nits (#1476)

* fix: reduce bottom padding of sidebar

* fix: text styling

* fix: padding on add section button

* chore: remove periods from validators

* chore: change placeholder text

* fix: update default values of new sections

* fix: copy changes

* fix(homepage): various styling fixes  (#1477)

* fix(edithomepage): fixed spacing between card/button

* fix(editable): fixed styling

* fix(editable): updated padding of editable accordion button

* fix(hero-highlight): fixed copy

* fix(editable): update padding

* fix(hero-higihlihgt-section): update wording

* refactor(formmediainput): add width

* fix(editable): fixed border radius on hover

---------

Co-authored-by: seaerchin <[email protected]>

* feat(editable): introduce new nested card variant (#1478)

* feat(icons): introduce new vertical draggable icon

* feat(editable): introduce nested version of accordion

* fix(contactus): update location card to use nested

* fix: border radius of error divider

* 0.42.0

---------

Co-authored-by: seaerchin <[email protected]>
Co-authored-by: Hsu Zhong Jun <[email protected]>
Co-authored-by: seaerchin <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@seaerchin seaerchin seaerchin approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@dcshzj @seaerchin