Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(contactus): styling fixes based on design feedback #1470

Merged
merged 3 commits into from
Sep 6, 2023
Merged

chore(contactus): styling fixes based on design feedback #1470

merged 3 commits into from
Sep 6, 2023

Conversation

dcshzj
Copy link
Contributor

@dcshzj dcshzj commented Sep 4, 2023 •
edited
Loading

Problem

Closes IS-538.

Solution

Breaking Changes

  • Yes - this PR contains breaking changes
  • No - this PR is backwards compatible

Improvements:

  • Some padding and copy changes were made based on the feedback obtained from @sehyunidaaa.

Tests

  • Unit tests (using npm run tests)
  • e2e tests (comment on this PR with the text !run e2e)
  • Smoke tests
    • When creating a new location and contact information card, the default card title should no longer be in titlecase
    • The bottom padding of the general information section should now be larger
    • The guiding information underneath the feedback form URL input box should be updated
    • "Remove operating hours" should be updated to say "Delete operating hours"
    • There should be more space between the "Add operating hours" and the last operating hours card
    • The Add section button should now be slightly bigger
    • The title text in an empty section should now be centre-aligned when the title text spills over to two lines
    • The extra spacing when scrolling the sidebar all the way to the bottom should now be removed
    • The size of the accordion of a non-draggable card should now be smaller
    • The title text of the empty section placeholder now uses subhead-1 text styling

Deploy Notes

None

@dcshzj dcshzj requested a review from a team September 4, 2023 06:29
@dcshzj dcshzj temporarily deployed to staging September 4, 2023 06:32 — with GitHub Actions Inactive
@dcshzj dcshzj temporarily deployed to staging September 4, 2023 06:42 — with GitHub Actions Inactive
seaerchin
seaerchin reviewed Sep 4, 2023
View reviewed changes
Copy link
Contributor

@seaerchin seaerchin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

1 sanity check wrt a change in GeneralInfoSection; for the rest of the changes in Editable, just confirming that these changes are cleared by design to be correct also for the rest of the pages

src/layouts/components/ContactUs/GeneralInfoSection.tsx Show resolved Hide resolved
src/layouts/components/Editable/AddSectionButton.tsx Show resolved Hide resolved
src/layouts/components/Editable/Editable.tsx Outdated Show resolved Hide resolved
src/layouts/components/Editable/Editable.tsx Show resolved Hide resolved
@dcshzj dcshzj temporarily deployed to staging September 4, 2023 08:59 — with GitHub Actions Inactive
@dcshzj dcshzj temporarily deployed to staging September 4, 2023 09:11 — with GitHub Actions Inactive
@dcshzj dcshzj temporarily deployed to staging September 4, 2023 09:20 — with GitHub Actions Inactive
@dcshzj dcshzj requested a review from a team September 4, 2023 09:20
@dcshzj dcshzj temporarily deployed to staging September 4, 2023 09:32 — with GitHub Actions Inactive
@dcshzj dcshzj merged commit a71e8da into develop Sep 6, 2023
@mergify mergify bot deleted the IS-538-contact-us-nits branch September 6, 2023 06:19
@alexanderleegs alexanderleegs mentioned this pull request Sep 7, 2023
Merged
24 tasks
alexanderleegs added a commit that referenced this pull request Sep 7, 2023
@alexanderleegs @seaerchin @dcshzj
Merge pull request #1480 from isomerpages/release/0.42.0
71474fe 
* feat: re-introduce comment-based trigger for Chromatic (#1468)

* chore(contactus): styling fixes based on design feedback (#1470)

* chore(contactus): styling fixes based on design feedback

* fix: use subhead-1 styling instead

* chore: remove unused import

* Chore/fix edit nav bar styles (#1466)

* fix: nav menu template styles

* fix: add spacing for legacy nav section

* chore: remove unused attributes

* chore: move flex into className

* Chore/fix title text (#1472)

* chore: fix title text

* chore: fix other instances of spacing

* fix(edithomepage): spread properly (#1474)

Co-authored-by: seaerchin <[email protected]>

* Fix/edit nav nits (#1476)

* fix: reduce bottom padding of sidebar

* fix: text styling

* fix: padding on add section button

* chore: remove periods from validators

* chore: change placeholder text

* fix: update default values of new sections

* fix: copy changes

* fix(homepage): various styling fixes  (#1477)

* fix(edithomepage): fixed spacing between card/button

* fix(editable): fixed styling

* fix(editable): updated padding of editable accordion button

* fix(hero-highlight): fixed copy

* fix(editable): update padding

* fix(hero-higihlihgt-section): update wording

* refactor(formmediainput): add width

* fix(editable): fixed border radius on hover

---------

Co-authored-by: seaerchin <[email protected]>

* feat(editable): introduce new nested card variant (#1478)

* feat(icons): introduce new vertical draggable icon

* feat(editable): introduce nested version of accordion

* fix(contactus): update location card to use nested

* fix: border radius of error divider

* 0.42.0

---------

Co-authored-by: seaerchin <[email protected]>
Co-authored-by: Hsu Zhong Jun <[email protected]>
Co-authored-by: seaerchin <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@seaerchin seaerchin seaerchin approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@dcshzj @seaerchin