release(v0.56.0): merge to prod #1050
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Added swagger doc for GIG DNS API * Modified the swagger doc to allow 1 DNS record per POST request * added 401 error response to all 3 API calls
Bumps [sequelize-typescript](https://github.com/RobinBuschmann/sequelize-typescript) from 2.1.5 to 2.1.6. - [Release notes](https://github.com/RobinBuschmann/sequelize-typescript/releases) - [Changelog](https://github.com/sequelize/sequelize-typescript/blob/master/CHANGELOG.md) - [Commits](sequelize/sequelize-typescript@v2.1.5...v2.1.6) --- updated-dependencies: - dependency-name: sequelize-typescript dependency-type: direct:production ... Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
## Problem Moving forward, since we have migrated most sites out of gh, we will only offer quickie for sites that are in ggs. As such, this pr removes the dependency of a no longer supported flow so as to allow for a simpler mental model. Additionally, there were weird abstractions bet GithubService + GithubCommitService -> removed the responsibilities to be isolated. Test cases will be added in the leaf node of these prs, cicd will also be fixed upstream.
## Problem Actual removal of the no longer needed `GithubCommitService` file to reduce complexity + fix test cases.
adding test cases for the two new functions `renameSinglePath` and `deleteDirectory` introduced into `GithubService` in #1042. Note that these functions already existed, but this pr adds the test cases to the right file.
## Problem 1. the presence of default arguments lead to sneaky bugs introduced due to caller unknowingly calling the wrong branch. 2. there is a scary instance whereby the lack of update to staging-lite could occur, but the update to staging does not, leading to issues downstream. Closes [insert issue #] ## Solution 1. to keep things simple, we make all the args compulsory. 2. make staging update first before updating staging lite.
add test cases for `GitFileCommitService`.
* fix(rollback handler): convert to ts for safety * Untitled commit * Untitled commit * Untitled commit * Untitled commit * fix(retry): add max 5 retries) * feat(loggin): add logging for possibility of alarm * feat(style): use resultAsync for clarity + refactor * fix(privatisation): should be write handler
|
|
|
|
kishore03109
approved these changes
Dec 6, 2023
Merged
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What's Changed
Full Changelog: v0.55.0...v0.56.0