feat(quickie): only gitfile should have quickie

[kishore03109]

Problem

Moving forward, since we have migrated most sites out of gh, we will only offer quickie for sites that are in ggs.
As such, this pr removes the dependency of a no longer supported flow so as to allow for a simpler mental model.
Additionally, there were weird abstractions bet GithubService + GithubCommitService -> removed the responsibilities to be isolated.

Test cases will be added in the leaf node of these prs, cicd will also be fixed upstream.

[kishore03109]

Current dependencies on/for this PR:

• develop
  • PR hotfix(repair-form): set remote url correctly #1048
    • PR feat(quickie): only gitfile should have quickie #1042 👈
      • PR chore(quickie): delete quickie for gh #1043
        • PR test(githubService): add tests #1045
          • PR feat(gitFileSystem): safer api #1046
            • PR test(gitCommitService): add test cases #1047
              • PR fix(rollback handler): convert to ts for safety #1044

This stack of pull requests is managed by Graphite.

[seaerchin]

I'm actually fine with this as-is, as long as we just remove the implementation in repo service with super.<new function in github service> so that it's clear where stuff is implemented

[seaerchin]

this method is functionally identical to the one in repoService - we could probably delete either this or replace the reposervice implementation with a super.deleteDirectory

[kishore03109]

good catch!
link to diff checker as a sanity check: https://www.diffchecker.com/4HWiYNIH/

[seaerchin]

not entirely sure wym here - the diff checker shows that there's 1 with the flagging functionality (which i assume is in repoService?) so we should keep the base and hte one that does the flagging functionality can just call super.

idk if this is done here or downstream (cos i see that this is still unchanged) but if it's resolved downstream, feel free to resolve this

[seaerchin]

lgtm; please either update the diffed method here or downstream prior to merge

[kishore03109]

@seaerchin for clarity

lgtm; please either update the diffed method here or downstream prior to merge

this is already done a0ae4c9. may i confirm that this is what your meant by update the drifed method here ?

[kishore03109]

Merge activity

• Dec 6, 5:51 AM: @kishore03109 started a stack merge that includes this pull request via Graphite.
• Dec 6, 5:51 AM: @kishore03109 merged this pull request with Graphite.