Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(web): Add custom top login button item to VMST "My Pages" page #17453

Merged
merged 2 commits into from
Jan 9, 2025

Conversation

RunarVestmann
Copy link
Member

@RunarVestmann RunarVestmann commented Jan 9, 2025

Add custom top login button item to VMST "My Pages" page

Checklist:

  • I have performed a self-review of my own code
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • Formatting passes locally with my changes
  • I have rebased against main before asking for a review

Summary by CodeRabbit

  • New Features
    • Enhanced organization page data retrieval with additional namespace-specific information
    • Added conditional top login button configuration based on organization details

@RunarVestmann RunarVestmann added the deprecated:automerge (Disabled) Merge this PR as soon as all checks pass label Jan 9, 2025
@RunarVestmann RunarVestmann requested a review from a team as a code owner January 9, 2025 10:33
Copy link
Contributor

coderabbitai bot commented Jan 9, 2025

Walkthrough

The pull request modifies the MyPages.getProps method in the DirectorateOfLabour organization screen. It introduces a new utility function extractNamespaceFromOrganization to extract the organization namespace. The method now includes a customTopLoginButtonItem in its return value, which is derived from the extracted organization namespace. This change enhances the data processing and return mechanism for the organization page.

Changes

File Change Summary
apps/web/screens/Organization/DirectorateOfLabour/MyPages.tsx - Added import for extractNamespaceFromOrganization utility function
- Modified getProps method to extract organization namespace
- Updated return object to include customTopLoginButtonItem

Possibly related PRs

Suggested reviewers

  • mannipje
  • peturgq
  • magnearun

Finishing Touches

  • 📝 Generate Docstrings

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai generate docstrings to generate docstrings for this PR. (Beta)
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@datadog-island-is
Copy link

datadog-island-is bot commented Jan 9, 2025

Datadog Report

Branch report: feature/web-mypages-vmst-menu-item
Commit report: 081ac22
Test service: web

✅ 0 Failed, 84 Passed, 0 Skipped, 32.84s Total Time
➡️ Test Sessions change in coverage: 1 no change

Copy link

codecov bot commented Jan 9, 2025

Codecov Report

Attention: Patch coverage is 0% with 1 line in your changes missing coverage. Please review.

Project coverage is 35.66%. Comparing base (1aa26d4) to head (0324066).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
...reens/Organization/DirectorateOfLabour/MyPages.tsx 0.00% 1 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##             main   #17453   +/-   ##
=======================================
  Coverage   35.66%   35.66%           
=======================================
  Files        6941     6941           
  Lines      149148   149149    +1     
  Branches    42651    42651           
=======================================
+ Hits        53195    53196    +1     
  Misses      95953    95953           
Flag Coverage Δ
web 2.39% <0.00%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
...reens/Organization/DirectorateOfLabour/MyPages.tsx 0.00% <0.00%> (ø)

... and 2 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1aa26d4...0324066. Read the comment docs.

Copy link
Contributor

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1

📜 Review details

Configuration used: .coderabbit.yaml
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 1aa26d4 and 0324066.

📒 Files selected for processing (1)
  • apps/web/screens/Organization/DirectorateOfLabour/MyPages.tsx (2 hunks)
🧰 Additional context used
📓 Path-based instructions (1)
apps/web/screens/Organization/DirectorateOfLabour/MyPages.tsx (1)

Pattern apps/**/*: "Confirm that the code adheres to the following:

  • NextJS best practices, including file structure, API routes, and static generation methods.
  • Efficient state management and server-side rendering techniques.
  • Optimal use of TypeScript for component and utility type safety."
⏰ Context from checks skipped due to timeout of 90000ms (10)
  • GitHub Check: build (web)
  • GitHub Check: build (web)
  • GitHub Check: build (web)
  • GitHub Check: build (web)
  • GitHub Check: build (web)
  • GitHub Check: build (web)
  • GitHub Check: build (web)
  • GitHub Check: build (web)
  • GitHub Check: build (web)
  • GitHub Check: build (web)
🔇 Additional comments (2)
apps/web/screens/Organization/DirectorateOfLabour/MyPages.tsx (2)

29-29: LGTM! Clean import statement.

The import follows TypeScript conventions and aligns with the PR objective.


170-170: Add validation and fallback for customTopLoginButtonItem.

The optional chaining suggests organizationNamespace might be undefined. Consider adding validation and a fallback value.

-    customTopLoginButtonItem: organizationNamespace?.customTopLoginButtonItem,
+    customTopLoginButtonItem: organizationNamespace?.customTopLoginButtonItem ?? null,

@kodiakhq kodiakhq bot merged commit a2d6db8 into main Jan 9, 2025
35 checks passed
@kodiakhq kodiakhq bot deleted the feature/web-mypages-vmst-menu-item branch January 9, 2025 11:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
deprecated:automerge (Disabled) Merge this PR as soon as all checks pass
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants