fix(web): In case no organization page is found we still want to potentially render a frontpage #17116
Conversation
WalkthroughThe changes in this pull request modify the error handling logic within the Changes
Possibly related PRs
Suggested labels
Suggested reviewers
Warning There were issues while running some tools. Please review the errors and either fix the tool’s configuration or disable the tool if it’s a critical failure. 🔧 eslint
warning [email protected]: This version is no longer supported. Please see https://eslint.org/version-support for other options. Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
Documentation and Community
|
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #17116 +/- ##
==========================================
- Coverage 35.72% 35.70% -0.02%
==========================================
Files 6920 6916 -4
Lines 147498 147270 -228
Branches 42001 41903 -98
==========================================
- Hits 52688 52582 -106
+ Misses 94810 94688 -122
Flags with carried forward coverage won't be shown. Click here to find out more.
... and 42 files with indirect coverage changes Continue to review full report in Codecov by Sentry.
|
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 2
📜 Review details
Configuration used: .coderabbit.yaml
Review profile: CHILL
📒 Files selected for processing (1)
apps/web/pages/s/[...slugs]/index.tsx(1 hunks)
🧰 Additional context used
📓 Path-based instructions (1)
apps/web/pages/s/[...slugs]/index.tsx (1)
Pattern apps/**/*: "Confirm that the code adheres to the following:
- NextJS best practices, including file structure, API routes, and static generation methods.
- Efficient state management and server-side rendering techniques.
- Optimal use of TypeScript for component and utility type safety."
Datadog ReportAll test runs ✅ 9 Total Test Services: 0 Failed, 9 Passed Test Services
|
kodiakhq
bot
deleted the
fix/web-organization-pages-can-be-a-landing-page
branch
In case no organization page is found we still want to potentially render a frontpage
What
A bugfix regarding "landing pages" for organizations not appearing.
This bug was introduced after routes were moved into a single file (it was forgotten that the "organization page" content type isn't required to render a landing page)
Before
Screen.Recording.2024-12-03.at.15.55.15.mov
After
Screen.Recording.2024-12-03.at.15.55.51.mov
Checklist:
Summary by CodeRabbit
New Features
Bug Fixes