fix(estate): text tweak #16546
fix(estate): text tweak #16546
Conversation
WalkthroughThe pull request includes modifications to localization strings and form configurations across several files. In Changes
Possibly related PRs
Suggested reviewers
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
Documentation and Community
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #16546 +/- ##
=======================================
Coverage 36.76% 36.76%
=======================================
Files 6851 6851
Lines 142129 142129
Branches 40546 40546
=======================================
Hits 52251 52251
Misses 89878 89878
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report in Codecov by Sentry.
|
Datadog ReportAll test runs ✅ 4 Total Test Services: 0 Failed, 4 Passed Test Services
|
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 0
🧹 Outside diff range and nitpick comments (2)
libs/application/templates/estate/src/forms/Done.ts (1)
Line range hint
1-7: Consider removing unused import.The
coreMessagesimport is no longer used after the migration to localized messages.import { buildForm, buildMultiField, getValueViaPath, buildMessageWithLinkButtonField, - coreMessages, buildImageField, } from '@island.is/application/core'libs/application/templates/estate/src/lib/messages.ts (1)
1008-1018: Consider adding descriptions for the new messages.The new service portal messages are well-structured, but consider adding meaningful descriptions to help other developers understand the context and usage of these messages.
openServicePortalTitle: { id: 'es.application:openServicePortalTitle', defaultMessage: 'Mínar síður', - description: '', + description: 'Title for the service portal link button', }, openServicePortalMessage: { id: 'es.application:openServicePortalMessage', defaultMessage: 'Inni á Mínum síðum og í Ísland.is appinu hefur þú aðgang að þínum upplýsingum, Stafrænu pósthólfi og stöðu umsóknar.', - description: '', + description: 'Informational message about accessing personal data in the service portal', },
📜 Review details
Configuration used: .coderabbit.yaml
Review profile: CHILL
📒 Files selected for processing (3)
- libs/application/templates/estate/src/forms/Done.ts (1 hunks)
- libs/application/templates/estate/src/lib/messages.ts (2 hunks)
- libs/application/templates/inheritance-report/src/lib/messages.ts (1 hunks)
✅ Files skipped from review due to trivial changes (1)
- libs/application/templates/inheritance-report/src/lib/messages.ts
🧰 Additional context used
📓 Path-based instructions (2)
libs/application/templates/estate/src/forms/Done.ts (1)
Pattern
libs/**/*: "Confirm that the code adheres to the following:
- Reusability of components and hooks across different NextJS apps.
- TypeScript usage for defining props and exporting types.
- Effective tree-shaking and bundling practices."
libs/application/templates/estate/src/lib/messages.ts (1)
Pattern
libs/**/*: "Confirm that the code adheres to the following:
- Reusability of components and hooks across different NextJS apps.
- TypeScript usage for defining props and exporting types.
- Effective tree-shaking and bundling practices."
🔇 Additional comments (2)
libs/application/templates/estate/src/forms/Done.ts (1)
49-50: LGTM! The message reference updates look correct.The changes appropriately move from core messages to localized messages, maintaining better separation of concerns.
Let's verify that these message keys exist in the localization file:
✅ Verification successful
Message keys are properly defined in the localization file
The verification confirms that both
openServicePortalTitleandopenServicePortalMessagekeys are correctly defined inlibs/application/templates/estate/src/lib/messages.ts, with appropriate namespacing (es.application:). The message reference updates in the code are valid and properly mapped.🏁 Scripts executed
The following scripts were executed for the analysis:
Script:
#!/bin/bash # Description: Verify that the required message keys exist in the messages file # Expected: Should find both openServicePortalTitle and openServicePortalMessage rg "openServicePortalTitle|openServicePortalMessage" "libs/application/templates/estate/src/lib/messages.ts"Length of output: 266
libs/application/templates/estate/src/lib/messages.ts (1)
Line range hint
966-970: LGTM: Message ID updated to reflect markdown formatting.The change correctly reflects the use of italic formatting in the message content.
Checklist:
Summary by CodeRabbit