Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(native-app): optional chaining for content.value and data.[0].mileage #16003

Merged
merged 4 commits into from
Sep 16, 2024
Merged

fix(native-app): optional chaining for content.value and data.[0].mileage #16003

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
e27b6ef
fix: optional chaining for content.value
thoreyjona Sep 13, 2024
4bb4ab8
fix: optional chaining for mileage as well
thoreyjona Sep 13, 2024
5d15e07
fix: better fix
thoreyjona Sep 13, 2024
f479706
Merge branch 'main' into fix/document-detail-error
kodiakhq[bot] Sep 16, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 8 additions & 7 deletions apps/native/app/src/screens/document-detail/document-detail.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -374,13 +374,14 @@ export const DocumentDetailScreen: NavigationFunctionComponent<{
(isHtml ? (
<WebView
source={{
html:
// Removing all <br /> tags to fix a bug in react-native that renders <br /> with too much vertical space
// https://github.com/facebook/react-native/issues/32062
`${htmlStyles}${Document.content?.value.replaceAll(
regexForBr,
'',
)}` ?? '',
html: Document.content?.value
? // Removing all <br /> tags to fix a bug in react-native that renders <br /> with too much vertical space
// https://github.com/facebook/react-native/issues/32062
`${htmlStyles}${Document.content?.value.replaceAll(
regexForBr,
'',
)}`
: '',
}}
scalesPageToFit
onLoadEnd={() => {
Expand Down
2 changes: 1 addition & 1 deletion apps/native/app/src/screens/vehicles/vehicle-mileage.screen.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -113,7 +113,7 @@ export const VehicleMileageScreen: NavigationFunctionComponent<{
}, [res.data, res.loading])

const latestMileage =
data?.[0]?.__typename !== 'Skeleton' && data[0].mileage
data?.[0]?.__typename !== 'Skeleton' && data[0]?.mileage
? // Parse mileage from string to number
+data[0].mileage
: 0
Expand Down