fix(service-portal): action card tag if no heading

[thorkellmani]

What

• Display tags on very small screen sizes if heading is missing

Why

Wasn't displaying tags on mobile

Checklist:

• I have performed a self-review of my own code
• I have made corresponding changes to the documentation
• My changes generate no new warnings
• I have added tests that prove my fix is effective or that my feature works
• Formatting passes locally with my changes
• I have rebased against main before asking for a review

Summary by CodeRabbit

• Refactor
  • Improved the display logic for headings and text within the ActionCard component to ensure proper conditional rendering based on their presence.

[coderabbitai]

Walkthrough

The changes in ActionCard.tsx focus on reordering the rendering logic for the heading and text elements within the ActionCard component. This adjustment ensures that these elements are conditionally rendered in the correct order based on their presence, enhancing the display accuracy of the component.

Changes

Files	Change Summary
libs/service-portal/core/src/components/ActionCard/ActionCard.tsx	Reordered the rendering logic for heading and text elements to ensure proper conditional display.

---

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share

• X
• Mastodon
• Reddit
• LinkedIn

Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>.
  • Generate unit testing code for this file.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai generate unit testing code for this file.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai generate interesting stats about this repository and render them as a table.
  • @coderabbitai show all the console.log statements in this repository.
  • @coderabbitai read src/utils.ts and generate unit testing code.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
  • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (invoked as PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai full review to do a full review from scratch and review all the files again.
• @coderabbitai summary to regenerate the summary of the PR.
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
• @coderabbitai help to get help.

Additionally, you can add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Configration File (.coderabbit.yaml)

• You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
• Please see the configuration documentation for more information.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.

[coderabbitai]

Actionable comments posted: 0

Review details

Configuration used: .coderabbit.yaml
Review profile: CHILL

Commits

Files that changed from the base of the PR and between 9c499f8 and 1fac215.

Files selected for processing (1)

• libs/service-portal/core/src/components/ActionCard/ActionCard.tsx (2 hunks)

Additional context used

Path-based instructions (1)

libs/service-portal/core/src/components/ActionCard/ActionCard.tsx (1)

Pattern libs/**/*: "Confirm that the code adheres to the following:

• Reusability of components and hooks across different NextJS apps.
• TypeScript usage for defining props and exporting types.
• Effective tree-shaking and bundling practices."

Additional comments not posted (1)

libs/service-portal/core/src/components/ActionCard/ActionCard.tsx (1)

Line range hint 342-381:
LGTM! Changes ensure tags are displayed even without a heading.

The reordering of the rendering logic and the new conditional block effectively address the issue of tags not being displayed on very small screens when the heading is absent.

[datadog-island-is]

Datadog Report

All test runs 2214ef7 🔗

✅ 2 Total Test Services: 0 Failed, 1 Passed
➡️ Test Sessions change in coverage: 20 no change

Test Services

Service Name	Failed	Known Flaky	New Flaky	Passed	Skipped	Total Time	Code Coverage Change	Test Service View
service-portal-core	0	0	0	5	0	2.25s	N/A	Link
service-portal-health	0	0	0	0	0	567.11ms	1 no change	Link

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 37.03%. Comparing base (0fb8095) to head (1fac215).
Report is 3 commits behind head on main.

Additional details and impacted files

@@            Coverage Diff             @@
##             main   #15497      +/-   ##
==========================================
+ Coverage   37.02%   37.03%   +0.01%     
==========================================
  Files        6557     6557              
  Lines      134038   134083      +45     
  Branches    38377    38389      +12     
==========================================
+ Hits        49633    49664      +31     
- Misses      84405    84419      +14     

Flag	Coverage Δ
judicial-system-api	18.17% <ø> (+<0.01%)	⬆️
judicial-system-formatters	80.53% <ø> (+0.02%)	⬆️
judicial-system-message	66.33% <ø> (ø)
judicial-system-message-handler	66.13% <ø> (+0.03%)	⬆️
judicial-system-types	50.35% <ø> (-0.01%)	⬇️
judicial-system-web	28.37% <ø> (-0.01%)	⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files	Coverage Δ
...rtal/core/src/components/ActionCard/ActionCard.tsx	5.00% <ø> (+0.18%)	⬆️

... and 3 files with indirect coverage changes

---

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 99b1814...1fac215. Read the comment docs.