-
Notifications
You must be signed in to change notification settings - Fork 61
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(j-s): Sort cases by IndictmentAppealDeadline #15336
Conversation
…to j-s/deadline-sort
WalkthroughThe updates focus on enhancing the sorting functionality within various tables in the judicial system web application. Noteworthy changes include altering sorting keys from 'defendant' to 'defendants' and from 'createdAt' to 'created', updating table components to use these new keys, and adjusting type definitions to reflect these updates. Additionally, several utility wrappers have been refactored to use functional component syntax with TypeScript props for better code consistency and readability. Changes
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (invoked as PR comments)
Additionally, you can add CodeRabbit Configration File (
|
Datadog ReportAll test runs ✅ 6 Total Test Services: 0 Failed, 6 Passed Test Services
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 1
Outside diff range and nitpick comments (1)
apps/judicial-system/web/src/components/Table/Table.tsx (1)
Line range hint
194-206
: Add keyboard accessibility for row click actionsThe table rows are clickable but lack corresponding keyboard event handlers, which is necessary for accessibility compliance.
- onClick={() => { if (!onClick?.(row)) { handleOpenCase(row.id) } }} + onClick={() => { if (!onClick?.(row)) { handleOpenCase(row.id) } }} + onKeyUp={(event) => { if (event.key === 'Enter') handleOpenCase(row.id) }}
Review details
Configuration used: .coderabbit.yaml
Review profile: CHILL
Files selected for processing (14)
- apps/judicial-system/web/src/components/Table/AppealCasesTable/AppealCasesTable.tsx (1 hunks)
- apps/judicial-system/web/src/components/Table/SortButton/SortButton.tsx (1 hunks)
- apps/judicial-system/web/src/components/Table/Table.spec.tsx (1 hunks)
- apps/judicial-system/web/src/components/Table/Table.tsx (7 hunks)
- apps/judicial-system/web/src/routes/Court/components/CasesAwaitingAssignmentTable/CasesAwaitingAssignmentTable.tsx (2 hunks)
- apps/judicial-system/web/src/routes/Court/components/CasesInProgressTable/CasesInProgressTable.tsx (1 hunks)
- apps/judicial-system/web/src/routes/Prosecutor/components/CasesAwaitingConfirmationTable/CasesAwaitingConfirmationTable.tsx (1 hunks)
- apps/judicial-system/web/src/routes/PublicProsecutor/Tables/CasesAwaitingReview.tsx (1 hunks)
- apps/judicial-system/web/src/routes/PublicProsecutor/Tables/CasesForReview.tsx (4 hunks)
- apps/judicial-system/web/src/routes/PublicProsecutor/Tables/CasesReviewed.tsx (1 hunks)
- apps/judicial-system/web/src/routes/Shared/Cases/ActiveCases.tsx (3 hunks)
- apps/judicial-system/web/src/routes/Shared/Cases/PrisonCases.tsx (1 hunks)
- apps/judicial-system/web/src/types/index.ts (2 hunks)
- apps/judicial-system/web/src/utils/testHelpers.tsx (3 hunks)
Files not reviewed due to errors (1)
- apps/judicial-system/web/src/utils/testHelpers.tsx (no review received)
Files skipped from review due to trivial changes (4)
- apps/judicial-system/web/src/components/Table/SortButton/SortButton.tsx
- apps/judicial-system/web/src/routes/PublicProsecutor/Tables/CasesReviewed.tsx
- apps/judicial-system/web/src/routes/Shared/Cases/PrisonCases.tsx
- apps/judicial-system/web/src/types/index.ts
Additional context used
Path-based instructions (10)
apps/judicial-system/web/src/utils/testHelpers.tsx (1)
Pattern
apps/**/*
: "Confirm that the code adheres to the following:
- NextJS best practices, including file structure, API routes, and static generation methods.
- Efficient state management and server-side rendering techniques.
- Optimal use of TypeScript for component and utility type safety."
apps/judicial-system/web/src/components/Table/Table.spec.tsx (1)
Pattern
apps/**/*
: "Confirm that the code adheres to the following:
- NextJS best practices, including file structure, API routes, and static generation methods.
- Efficient state management and server-side rendering techniques.
- Optimal use of TypeScript for component and utility type safety."
apps/judicial-system/web/src/routes/Court/components/CasesAwaitingAssignmentTable/CasesAwaitingAssignmentTable.tsx (1)
Pattern
apps/**/*
: "Confirm that the code adheres to the following:
- NextJS best practices, including file structure, API routes, and static generation methods.
- Efficient state management and server-side rendering techniques.
- Optimal use of TypeScript for component and utility type safety."
apps/judicial-system/web/src/routes/PublicProsecutor/Tables/CasesAwaitingReview.tsx (1)
Pattern
apps/**/*
: "Confirm that the code adheres to the following:
- NextJS best practices, including file structure, API routes, and static generation methods.
- Efficient state management and server-side rendering techniques.
- Optimal use of TypeScript for component and utility type safety."
apps/judicial-system/web/src/routes/PublicProsecutor/Tables/CasesForReview.tsx (1)
Pattern
apps/**/*
: "Confirm that the code adheres to the following:
- NextJS best practices, including file structure, API routes, and static generation methods.
- Efficient state management and server-side rendering techniques.
- Optimal use of TypeScript for component and utility type safety."
apps/judicial-system/web/src/routes/Prosecutor/components/CasesAwaitingConfirmationTable/CasesAwaitingConfirmationTable.tsx (1)
Pattern
apps/**/*
: "Confirm that the code adheres to the following:
- NextJS best practices, including file structure, API routes, and static generation methods.
- Efficient state management and server-side rendering techniques.
- Optimal use of TypeScript for component and utility type safety."
apps/judicial-system/web/src/components/Table/AppealCasesTable/AppealCasesTable.tsx (1)
Pattern
apps/**/*
: "Confirm that the code adheres to the following:
- NextJS best practices, including file structure, API routes, and static generation methods.
- Efficient state management and server-side rendering techniques.
- Optimal use of TypeScript for component and utility type safety."
apps/judicial-system/web/src/routes/Court/components/CasesInProgressTable/CasesInProgressTable.tsx (1)
Pattern
apps/**/*
: "Confirm that the code adheres to the following:
- NextJS best practices, including file structure, API routes, and static generation methods.
- Efficient state management and server-side rendering techniques.
- Optimal use of TypeScript for component and utility type safety."
apps/judicial-system/web/src/components/Table/Table.tsx (1)
Pattern
apps/**/*
: "Confirm that the code adheres to the following:
- NextJS best practices, including file structure, API routes, and static generation methods.
- Efficient state management and server-side rendering techniques.
- Optimal use of TypeScript for component and utility type safety."
apps/judicial-system/web/src/routes/Shared/Cases/ActiveCases.tsx (1)
Pattern
apps/**/*
: "Confirm that the code adheres to the following:
- NextJS best practices, including file structure, API routes, and static generation methods.
- Efficient state management and server-side rendering techniques.
- Optimal use of TypeScript for component and utility type safety."
Biome
apps/judicial-system/web/src/components/Table/Table.tsx
[error] 194-206: Enforce to have the onClick mouse event with the onKeyUp, the onKeyDown, or the onKeyPress keyboard event. (lint/a11y/useKeyWithClickEvents)
Actions triggered using mouse events should have corresponding keyboard events to account for keyboard-only navigation.
Additional comments not posted (9)
apps/judicial-system/web/src/components/Table/Table.spec.tsx (1)
28-90
: Ensure correct behavior in sorting test forTable
.This test checks the sorting functionality of the
Table
component by theindictmentAppealDeadline
. Ensure that the test adequately covers both ascending and descending orders and that the test setup correctly mocks or isolates dependencies.apps/judicial-system/web/src/routes/PublicProsecutor/Tables/CasesAwaitingReview.tsx (1)
52-52
: Approval of sorting functionality addition inCasesAwaitingReview
.The addition of a new sortable column for 'indictmentAppealDeadline' aligns with the PR's objectives to improve case management by sorting based on deadlines. Ensure that the backend supports this key and that it correctly interacts with the sorting mechanism.
Also applies to: 56-61
apps/judicial-system/web/src/routes/PublicProsecutor/Tables/CasesForReview.tsx (1)
49-52
: Review the implementation of new sortable columns inCasesForReview
.The changes to add 'defendants' and 'indictmentAppealDeadline' as sortable columns are crucial for enhancing the usability of the table. Confirm that these keys are supported on the backend and that the UI updates correctly reflect the sorted data.
Also applies to: 56-61
apps/judicial-system/web/src/routes/Prosecutor/components/CasesAwaitingConfirmationTable/CasesAwaitingConfirmationTable.tsx (2)
61-61
: Updated sorting key for defendantsThe sorting key for defendants has been updated from 'defendant' to 'defendants'. Ensure that this change aligns with the backend schema and other frontend components where sorting might be affected.
Verification successful
Updated sorting key for defendants
The verification confirms that the key 'defendants' is used extensively across the frontend and backend components, aligning with the updated sorting key change. This ensures consistency and proper functionality across the system.
- The key 'defendants' is found in various frontend components, including sorting configurations and data handling.
- The backend schema also supports 'defendants', as evidenced by its presence in GraphQL queries, TypeScript files, and backend services.
Scripts executed
The following scripts were executed for the analysis:
Script:
#!/bin/bash # Description: Verify that the backend schema and other frontend components align with the new sorting key 'defendants'. ast-grep --lang typescript --pattern $'sortable: { isSortable: true, key: "defendants" }'Length of output: 90
Script:
#!/bin/bash # Description: Check if the sorting key 'defendants' is used elsewhere in the frontend components. rg 'key: "defendants"' # Description: Check if the backend schema supports the 'defendants' key. rg 'defendants' --glob '*.graphql' --glob '*.ts' --glob '*.tsx'Length of output: 63635
68-68
: Updated sorting key for created dateThe sorting key for the created date has been updated from 'createdAt' to 'created'. This change should be consistently applied across the backend and other components that might use this sorting key.
Verification successful
Updated sorting key for created date
The sorting key for the created date has been updated from 'createdAt' to 'created'. The search results confirm that the new sorting key 'created' is used consistently across the backend and other frontend components.
- Backend Components: Multiple files in the backend show usage of 'created' as the sorting key.
- Frontend Components: The 'created' key is also found in various frontend TypeScript files.
No further action required.
Scripts executed
The following scripts were executed for the analysis:
Script:
#!/bin/bash # Description: Verify that the backend schema and other frontend components align with the new sorting key 'created'. ast-grep --lang typescript --pattern $'sortable: { isSortable: true, key: "created" }'Length of output: 87
Script:
#!/bin/bash # Verify the usage of the new sorting key 'created' in the frontend components rg 'key: "created"' --glob='*.tsx' --glob='*.ts' # Verify the usage of the new sorting key 'created' in the backend components rg 'created' --glob='*.ts' --glob='*.js'Length of output: 118766
apps/judicial-system/web/src/components/Table/AppealCasesTable/AppealCasesTable.tsx (1)
80-80
: Updated sorting key for defendants in AppealCasesTableThe sorting key for defendants has been updated to 'defendants'. This change should be verified to ensure that it aligns with the data structure expected by the backend and other frontend components.
Verification successful
Updated sorting key for defendants in AppealCasesTable
The sorting key 'defendants' is widely used across both frontend and backend components, ensuring consistency with the new sorting key in the
AppealCasesTable
. The key 'defendants' appears in various files and contexts, indicating that it aligns with the data structure expected by the backend and other frontend components.
- Frontend Components: The key 'defendants' is used in multiple components, such as
Table.tsx
,MobilePastCase.tsx
,DefendantInfo.tsx
, and others.- Backend Schema: The key 'defendants' is also present in backend files, such as
notification.service.ts
,case.service.ts
, and various test files.Files that need attention:
apps/judicial-system/web/src/components/Table/AppealCasesTable/AppealCasesTable.tsx
Scripts executed
The following scripts were executed for the analysis:
Script:
#!/bin/bash # Description: Verify that the backend schema and other frontend components align with the new sorting key 'defendants' in AppealCasesTable. ast-grep --lang typescript --pattern $'sortable: { isSortable: true, key: "defendants" }'Length of output: 90
Script:
#!/bin/bash # Search for the usage of 'defendants' as a sorting key in backend-related files. rg 'defendants' --type ts --type tsx --type graphql # Search for the usage of 'defendants' in other frontend components. rg 'defendants' --type ts --type tsxLength of output: 144
Script:
#!/bin/bash # Search for the usage of 'defendants' as a sorting key in backend-related files. rg 'defendants' --type typescript --type graphql # Search for the usage of 'defendants' in other frontend components. rg 'defendants' --type typescriptLength of output: 152
Script:
#!/bin/bash # Search for the usage of 'defendants' as a sorting key in backend-related files. rg 'defendants' --type ts --type graphql # Search for the usage of 'defendants' in other frontend components. rg 'defendants' --type tsLength of output: 62848
apps/judicial-system/web/src/routes/Court/components/CasesInProgressTable/CasesInProgressTable.tsx (1)
115-115
: Updated sorting keys for defendants and created date in CasesInProgressTableThe sorting keys for defendants and created date have been updated. Confirm that these changes are consistent across all related components and the backend schema.
Also applies to: 122-122
apps/judicial-system/web/src/components/Table/Table.tsx (1)
106-113
: Ensure consistent sorting logic for defendant namesThe sorting logic for defendant names checks for the existence of the first defendant's name. Ensure that this logic correctly handles cases where defendant information might be partially missing or formatted differently.
Verification successful
Consistent sorting logic for defendant names verified
The sorting logic for defendant names in the identified files (
useSortCases.ts
anduseSortAppealCases.ts
) ensures robustness by providing a default empty string when the name is missing. This confirms that the logic handles cases where defendant information might be partially missing.
apps/judicial-system/web/src/utils/hooks/useSort/useSortCases.ts:50
apps/judicial-system/web/src/utils/hooks/useSort/useSortAppealCases.ts:49
Scripts executed
The following scripts were executed for the analysis:
Script:
#!/bin/bash # Description: Verify the consistency and robustness of sorting logic for defendant names in various components. ast-grep --lang typescript --pattern $'entry.defendants[0].name'Length of output: 311
apps/judicial-system/web/src/routes/Shared/Cases/ActiveCases.tsx (1)
181-184
: Updated sorting keys for defendants and created date in ActiveCasesThe sorting keys for defendants and created date have been updated to 'defendants' and 'created', respectively. Confirm that these keys are consistently used across all relevant components and back-end schemas.
Also applies to: 198-201
Verification successful
Consistent Usage of Sorting Keys 'defendants' and 'created' Verified
The sorting keys 'defendants' and 'created' are consistently used across the frontend components and backend schemas.
Frontend:
apps/judicial-system/web/src/routes/Shared/Cases/ActiveCases.tsx
apps/judicial-system/web/src/routes/Shared/Cases/PrisonCases.tsx
apps/judicial-system/web/src/routes/PublicProsecutor/Tables/CasesForReview.tsx
apps/judicial-system/web/src/routes/Court/components/CasesInProgressTable/CasesInProgressTable.tsx
apps/judicial-system/web/src/routes/Court/components/CasesAwaitingAssignmentTable/CasesAwaitingAssignmentTable.tsx
Backend:
apps/judicial-system/backend/src/app/modules/case/models/case.model.ts
apps/judicial-system/backend/src/app/modules/case/internalCase.service.ts
apps/judicial-system/backend/src/app/modules/notification/notification.service.ts
These results confirm that the sorting keys 'defendants' and 'created' are correctly implemented and used consistently across the codebase.
Scripts executed
The following scripts were executed for the analysis:
Script:
#!/bin/bash # Description: Verify that the backend schema and other frontend components align with the new sorting keys 'defendants' and 'created' in ActiveCases. ast-grep --lang typescript --pattern $'sortable: { isSortable: true, key: "defendants" }' ast-grep --lang typescript --pattern $'sortable: { isSortable: true, key: "created" }'Length of output: 178
Script:
#!/bin/bash # Description: Verify that the sorting keys 'defendants' and 'created' are used in the frontend components. # Searching for 'defendants' and 'created' in the frontend code. rg 'defendants' --type js --type ts --type tsx rg 'created' --type js --type ts --type tsxLength of output: 146
Script:
#!/bin/bash # Description: Verify that the sorting keys 'defendants' and 'created' are used in the backend schemas. # Searching for 'defendants' and 'created' in the backend code. rg 'defendants' --type js --type ts rg 'created' --type js --type tsLength of output: 208240
...eb/src/routes/Court/components/CasesAwaitingAssignmentTable/CasesAwaitingAssignmentTable.tsx
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please fix broken build
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 2
Review details
Configuration used: .coderabbit.yaml
Review profile: CHILL
Files selected for processing (3)
- apps/judicial-system/web/src/components/Table/PastCasesTable/PastCasesTable.tsx (3 hunks)
- apps/judicial-system/web/src/routes/Defender/Cases/components/DefenderCasesTable.tsx (3 hunks)
- apps/judicial-system/web/src/utils/hooks/useSort/useSortCases.ts (4 hunks)
Files not reviewed due to errors (1)
- apps/judicial-system/web/src/utils/hooks/useSort/useSortCases.ts (no review received)
Additional context used
Path-based instructions (3)
apps/judicial-system/web/src/utils/hooks/useSort/useSortCases.ts (1)
Pattern
apps/**/*
: "Confirm that the code adheres to the following:
- NextJS best practices, including file structure, API routes, and static generation methods.
- Efficient state management and server-side rendering techniques.
- Optimal use of TypeScript for component and utility type safety."
apps/judicial-system/web/src/components/Table/PastCasesTable/PastCasesTable.tsx (1)
Pattern
apps/**/*
: "Confirm that the code adheres to the following:
- NextJS best practices, including file structure, API routes, and static generation methods.
- Efficient state management and server-side rendering techniques.
- Optimal use of TypeScript for component and utility type safety."
apps/judicial-system/web/src/routes/Defender/Cases/components/DefenderCasesTable.tsx (1)
Pattern
apps/**/*
: "Confirm that the code adheres to the following:
- NextJS best practices, including file structure, API routes, and static generation methods.
- Efficient state management and server-side rendering techniques.
- Optimal use of TypeScript for component and utility type safety."
Biome
apps/judicial-system/web/src/components/Table/PastCasesTable/PastCasesTable.tsx
[error] 137-141: Enforce to have the onClick mouse event with the onKeyUp, the onKeyDown, or the onKeyPress keyboard event. (lint/a11y/useKeyWithClickEvents)
Actions triggered using mouse events should have corresponding keyboard events to account for keyboard-only navigation.
apps/judicial-system/web/src/routes/Defender/Cases/components/DefenderCasesTable.tsx
[error] 126-130: Enforce to have the onClick mouse event with the onKeyUp, the onKeyDown, or the onKeyPress keyboard event. (lint/a11y/useKeyWithClickEvents)
Actions triggered using mouse events should have corresponding keyboard events to account for keyboard-only navigation.
Additional comments not posted (4)
apps/judicial-system/web/src/components/Table/PastCasesTable/PastCasesTable.tsx (3)
56-56
: Good use ofuseSortCases
hook.The
useSortCases
hook is used effectively to manage sorting state and operations. This encapsulation of sorting logic in a custom hook is a good practice, promoting reusability and separation of concerns.
123-126
: Keyboard accessibility needs attention.Similarly, ensure that sorting by 'created' is accessible via keyboard by adding corresponding keyboard event handlers.
[ISSue]+ onKeyUp={(event) => event.key === 'Enter' && requestSort('created')}
111-114
: Ensure consistent interaction for all users.The
SortButton
component interaction is currently only handled through mouse events. Consider adding keyboard event handlers to ensure accessibility for users who rely on keyboard navigation.+ onKeyUp={(event) => event.key === 'Enter' && requestSort('defendants')}
apps/judicial-system/web/src/routes/Defender/Cases/components/DefenderCasesTable.tsx (1)
51-51
: Effective use ofuseSortCases
in DefenderCasesTable.The hook
useSortCases
is utilized well here, similar to its use inPastCasesTable
. This consistency in handling sorting across different tables is good for maintainability.
apps/judicial-system/web/src/routes/Defender/Cases/components/DefenderCasesTable.tsx
Show resolved
Hide resolved
apps/judicial-system/web/src/routes/Defender/Cases/components/DefenderCasesTable.tsx
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 1
Review details
Configuration used: .coderabbit.yaml
Review profile: CHILL
Files selected for processing (3)
- apps/judicial-system/web/src/routes/Court/components/CasesInProgressTable/CasesInProgressTable.tsx (1 hunks)
- apps/judicial-system/web/src/routes/Defender/Cases/components/DefenderCasesTable.tsx (3 hunks)
- apps/judicial-system/web/src/routes/Shared/Cases/ActiveCases.tsx (3 hunks)
Files not reviewed due to errors (1)
- apps/judicial-system/web/src/routes/Court/components/CasesInProgressTable/CasesInProgressTable.tsx (no review received)
Additional context used
Path-based instructions (3)
apps/judicial-system/web/src/routes/Court/components/CasesInProgressTable/CasesInProgressTable.tsx (1)
Pattern
apps/**/*
: "Confirm that the code adheres to the following:
- NextJS best practices, including file structure, API routes, and static generation methods.
- Efficient state management and server-side rendering techniques.
- Optimal use of TypeScript for component and utility type safety."
apps/judicial-system/web/src/routes/Defender/Cases/components/DefenderCasesTable.tsx (1)
Pattern
apps/**/*
: "Confirm that the code adheres to the following:
- NextJS best practices, including file structure, API routes, and static generation methods.
- Efficient state management and server-side rendering techniques.
- Optimal use of TypeScript for component and utility type safety."
apps/judicial-system/web/src/routes/Shared/Cases/ActiveCases.tsx (1)
Pattern
apps/**/*
: "Confirm that the code adheres to the following:
- NextJS best practices, including file structure, API routes, and static generation methods.
- Efficient state management and server-side rendering techniques.
- Optimal use of TypeScript for component and utility type safety."
Biome
apps/judicial-system/web/src/routes/Defender/Cases/components/DefenderCasesTable.tsx
[error] 123-127: Enforce to have the onClick mouse event with the onKeyUp, the onKeyDown, or the onKeyPress keyboard event. (lint/a11y/useKeyWithClickEvents)
Actions triggered using mouse events should have corresponding keyboard events to account for keyboard-only navigation.
Additional comments not posted (3)
apps/judicial-system/web/src/routes/Defender/Cases/components/DefenderCasesTable.tsx (2)
77-80
: Accessibility improvements implemented.The addition of keyboard accessibility features for sorting buttons, as suggested in previous comments, has been correctly implemented. This ensures that the sorting functionality is accessible to users who rely on keyboard navigation.
Also applies to: 94-97
48-48
: Sorting functionality initialized correctly.The initialization of the sorting functionality using the 'created' column in descending order as a default setting is a good practice. It ensures that the users see the most recent cases first, which is likely the most common use case.
apps/judicial-system/web/src/routes/Shared/Cases/ActiveCases.tsx (1)
86-86
: Enhanced sorting logic for 'defendants'.The sorting logic now checks for the presence of defendants and sorts based on the first defendant's name if available. This is a thoughtful addition for cases where multiple defendants might be involved, ensuring the table is sorted meaningfully.
* Checkpoint * Checkpoint * Sort now works * Testing sort now works with existing sorting mechanims * Cleanup * sortableTableColumn now has better types * Fix build errors * Checkpoint * Tests correct * Refactor * Fix lint * Revert RTL update * Revert RTL update * Revert RTL update * Use better types --------- Co-authored-by: kodiakhq[bot] <49736102+kodiakhq[bot]@users.noreply.github.com>
* Checkpoint * Checkpoint * Sort now works * Testing sort now works with existing sorting mechanims * Cleanup * sortableTableColumn now has better types * Fix build errors * Checkpoint * Tests correct * Refactor * Fix lint * Revert RTL update * Revert RTL update * Revert RTL update * Use better types --------- Co-authored-by: kodiakhq[bot] <49736102+kodiakhq[bot]@users.noreply.github.com>
Sort cases by IndictmentAppealDeadline
Asana
What
Add a a sort button to CasesForReview and CasesAwaitingReview tables. The sort button sorts the cases by IndictmentAppealDeadline.
Why
The people at the Public prosecutors office want to be able to sort cases by deadline.
Note
There is a slight issue with the tests in this RP. When running the tests in
Table.spec.tsx
there is a warning logged to the console,Warning: The current testing environment is not configured to support act(...)
. I've created a ticket in Asana for this and we'll fix this in a later cooldown week.Screenshots / Gifs
Screen.Recording.2024-06-25.at.09.29.38.mov
Checklist:
Summary by CodeRabbit
Bug Fixes
New Features
Tests
Refactor
Chores