Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use GLIBCXX_USE_CXX11_ABI by default #6206

Merged
merged 2 commits into from
Jun 12, 2023
Merged

Conversation

QuentinTorg
Copy link
Contributor

@QuentinTorg QuentinTorg commented Jun 12, 2023

Set the GLIBCXX_USE_CXX11_ABI ON as default independent of the value of BUILD_SYCL_MODULE

Type

Motivation and Context

Previously the CXX11 ABI was off by default. #4387 was merged to fix this issue. Later, a regression was introduced with #5081 that made the default CXX11 ABI conditional on another variable. This once again changed the default CXX11 ABI back to the problematic case if no parameter was specified

Checklist:

  • I have run python util/check_style.py --apply to apply Open3D code style
    to my code.
  • This PR changes Open3D behavior or adds new functionality.
    • Both C++ (Doxygen) and Python (Sphinx / Google style) documentation is
      updated accordingly.
    • I have added or updated C++ and / or Python unit tests OR included test
      results
      (e.g. screenshots or numbers) here.
  • I will follow up and update the code if CI fails.
  • For fork PRs, I have selected Allow edits from maintainers.

Description

This PR removes the conditional check so that the CXX11 ABI will be used by default


This change is Reviewable

@update-docs
Copy link

update-docs bot commented Jun 12, 2023

Thanks for submitting this pull request! The maintainers of this repository would appreciate if you could update the CHANGELOG.md based on your changes.

@ssheorey
Copy link
Member

Hi @QuentinTorg thanks for the bug fix!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants