Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

initial SYCL build system and examples #5081

Merged
merged 15 commits into from
May 22, 2022
Merged

initial SYCL build system and examples #5081

merged 15 commits into from
May 22, 2022

Conversation

yxlao
Copy link
Collaborator

@yxlao yxlao commented May 6, 2022

  • Initial build system with SYCL
  • Python unit test, C++ unit test, C++ example, C++ linkage with as third-party lib are all working
  • CPU only, not tested with iGPU or dGPU
  • See 3rdparty/README_SYCL.md on how to set up the SYCL environment

This change is Reviewable

@yxlao yxlao requested review from benjaminum and ssheorey May 6, 2022 17:26
@update-docs
Copy link

update-docs bot commented May 6, 2022

Thanks for submitting this pull request! The maintainers of this repository would appreciate if you could update the CHANGELOG.md based on your changes.

@yxlao yxlao mentioned this pull request May 7, 2022
.github/workflows/ubuntu-sycl.yml Outdated Show resolved Hide resolved
3rdparty/assimp/assimp.cmake Outdated Show resolved Hide resolved
CMakeLists.txt Show resolved Hide resolved
CMakeLists.txt Show resolved Hide resolved
Copy link
Contributor

@benjaminum benjaminum left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewable status: 0 of 37 files reviewed, 6 unresolved discussions (waiting on @benjaminum, @ssheorey, and @yxlao)


3rdparty/find_dependencies.cmake line 1377 at r6 (raw file):

        message(STATUS "Using OneAPI packages from: $ENV{ONEAPI_ROOT}")
    else()
        message(FATAL_ERROR "OneAPI packages not found. Please run `source /opt/intel/oneapi/setvars.sh`")

Just a comment, the env var is not set for the conda distribution and is not used to find the packages as far as I know.
We can update when the conda problems with oneAPI are solved.

Copy link
Collaborator Author

@yxlao yxlao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewable status: 0 of 37 files reviewed, 6 unresolved discussions (waiting on @benjaminum and @ssheorey)


3rdparty/find_dependencies.cmake line 1377 at r6 (raw file):

Previously, benjaminum (Benjamin Ummenhofer) wrote…

Just a comment, the env var is not set for the conda distribution and is not used to find the packages as far as I know.
We can update when the conda problems with oneAPI are solved.

Sounds good, I'll remove this check for now.

@yxlao yxlao merged commit 336509b into master May 22, 2022
@yxlao yxlao deleted the yixing/sycl-build branch May 22, 2022 17:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants