-
Notifications
You must be signed in to change notification settings - Fork 2.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
initial SYCL build system and examples #5081
Conversation
Thanks for submitting this pull request! The maintainers of this repository would appreciate if you could update the CHANGELOG.md based on your changes. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewable status: 0 of 37 files reviewed, 6 unresolved discussions (waiting on @benjaminum, @ssheorey, and @yxlao)
3rdparty/find_dependencies.cmake
line 1377 at r6 (raw file):
message(STATUS "Using OneAPI packages from: $ENV{ONEAPI_ROOT}") else() message(FATAL_ERROR "OneAPI packages not found. Please run `source /opt/intel/oneapi/setvars.sh`")
Just a comment, the env var is not set for the conda distribution and is not used to find the packages as far as I know.
We can update when the conda problems with oneAPI are solved.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewable status: 0 of 37 files reviewed, 6 unresolved discussions (waiting on @benjaminum and @ssheorey)
3rdparty/find_dependencies.cmake
line 1377 at r6 (raw file):
Previously, benjaminum (Benjamin Ummenhofer) wrote…
Just a comment, the env var is not set for the conda distribution and is not used to find the packages as far as I know.
We can update when the conda problems with oneAPI are solved.
Sounds good, I'll remove this check for now.
3rdparty/README_SYCL.md
on how to set up the SYCL environmentThis change is