Fixes bug in math operation in omni.isaac.orbit.utils.math
#55
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Mayankm96
changed the title
omni.isaac.orbit.utils.math
|
@sasayesh Thanks a lot for sending the PR! Can you please also update the |
Mayankm96
reviewed
Apr 11, 2023
source/extensions/omni.isaac.orbit/omni/isaac/orbit/utils/math.py
Outdated
Show resolved
Hide resolved
Mayankm96
requested changes
Apr 11, 2023
Mayankm96
approved these changes
Apr 12, 2023
|
Thanks a lot! |
Mayankm96
added a commit
that referenced
this pull request
Jul 24, 2023
# Description The `launch.json` file is very user-specific. Previously this was always getting pushed along with other commits which led to merge conflicts when merging branches from different users. Now, the `launch.json` is generated from a template if it doesn't already exist in the `.vscode` directory. The users can modify the `.vscode/launch.json` as they please afterward, but their changes won't get pushed to git itself. Fixes #46 ## Type of change <!-- As you go through the list, delete the ones that are not applicable. --> - Bug fix (non-breaking change which fixes an issue) ## Checklist - [x] I have run the [`pre-commit` checks](https://pre-commit.com/) with `./orbit.sh --format` - [ ] I have made corresponding changes to the documentation - [x] My changes generate no new warnings - [ ] I have added tests that prove my fix is effective or that my feature works - [ ] I have updated the changelog and the corresponding version in the extension's `config/extension.toml` file
Mayankm96
added a commit
that referenced
this pull request
Dec 22, 2023
# Description The `launch.json` file is very user-specific. Previously this was always getting pushed along with other commits which led to merge conflicts when merging branches from different users. Now, the `launch.json` is generated from a template if it doesn't already exist in the `.vscode` directory. The users can modify the `.vscode/launch.json` as they please afterward, but their changes won't get pushed to git itself. Fixes #46 ## Type of change <!-- As you go through the list, delete the ones that are not applicable. --> - Bug fix (non-breaking change which fixes an issue) ## Checklist - [x] I have run the [`pre-commit` checks](https://pre-commit.com/) with `./orbit.sh --format` - [ ] I have made corresponding changes to the documentation - [x] My changes generate no new warnings - [ ] I have added tests that prove my fix is effective or that my feature works - [ ] I have updated the changelog and the corresponding version in the extension's `config/extension.toml` file
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixes bug in the math operations provided in
omni.isaac.orbit.utils.mathmodule:axis_angle_from_quat()doesn't properly handle quaternion with a negative w componentsubtract_frame_transforms()has a missing tf combine when calculating the translation partFixes #54
Type of change
Checklist
pre-commitchecks with./orbit.sh --formatconfig/extension.tomlfile