Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Corrects fisheye camera projection types in spawner configuration #1361

Open
wants to merge 4 commits into
base: main
Choose a base branch
from

Conversation

command-z-z
Copy link
Contributor

@command-z-z command-z-z commented Nov 2, 2024

Description

This MR fixes the support of fish-eye projection type. Actually, I don't find the proper fisheye type on Replicator camera website (maybe it's out of style).

Screenshot from 2024-10-31 23-15-24

I only check the cameraProjectionType in Raw USD Properties in Isaacsim GUI.

Screenshot from 2024-10-31 23-29-10

Fixes #1331

Type of change

  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

Screenshots

Before After
Screenshot from 2024-11-02 11-25-57 Screenshot from 2024-11-02 11-26-03

Checklist

  • I have run the pre-commit checks with ./isaaclab.sh --format
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • I have updated the changelog and the corresponding version in the extension's config/extension.toml file
  • I have added my name to the CONTRIBUTORS.md or my name already exists there

@Mayankm96 Mayankm96 changed the title fix: correct fisheye camera projection types Corrects fisheye camera projection types in spawner configuration Nov 3, 2024
@Mayankm96 Mayankm96 added the bug Something isn't working label Nov 3, 2024
Copy link
Contributor

@Mayankm96 Mayankm96 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot for the fix!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Bug Fixed for the fish eye config
2 participants