Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug Fixed for the fish eye config #1331

Closed
wang59695487 opened this issue Oct 29, 2024 · 4 comments · May be fixed by #1361
Closed

Bug Fixed for the fish eye config #1331

wang59695487 opened this issue Oct 29, 2024 · 4 comments · May be fixed by #1361

Comments

@wang59695487
Copy link

# FIXME: This throws a warning. Check with Replicator team if this is expected/known.

The issue originates from the project type in FisheyeCameraCfg(https://github.com/isaac-sim/IsaacLab/blob/main/source/extensions/omni.isaac.lab/omni/isaac/lab/sim/spawners/sensors/sensors_cfg.py#L171). To properly use the API in Isaac Sim Rep, it should be "fisheyePolynomial" rather than variations like "fisheye_polynomial".

  • fisheye_orthographic -> fisheyeOrthographic
  • fisheye_equidistant -> fisheyeEquidistant
  • fisheye_equisolid -> fisheyeEquisolid
  • fisheye_polynomial -> fisheyePolynomial
  • fisheye_spherical -> fisheyeSpherical
@command-z-z
Copy link
Contributor

You are right! I'm curious why such a big bug has not been fixed. I will raise a PR

@command-z-z
Copy link
Contributor

# FIXME: This throws a warning. Check with Replicator team if this is expected/known.

The issue originates from the project type in FisheyeCameraCfg(https://github.com/isaac-sim/IsaacLab/blob/main/source/extensions/omni.isaac.lab/omni/isaac/lab/sim/spawners/sensors/sensors_cfg.py#L171). To properly use the API in Isaac Sim Rep, it should be "fisheyePolynomial" rather than variations like "fisheye_polynomial".

  • fisheye_orthographic -> fisheyeOrthographic
  • fisheye_equidistant -> fisheyeEquidistant
  • fisheye_equisolid -> fisheyeEquisolid
  • fisheye_polynomial -> fisheyePolynomial
  • fisheye_spherical -> fisheyeSpherical

hi, I would like to know how you know the correct camera projection_type parameters. I checked the informations on Replicator camera website. Only finding the following type, Acttually, fisheye_polynomial isn't the correct parameter.
Screenshot from 2024-10-31 23-15-24.

@command-z-z
Copy link
Contributor

command-z-z commented Oct 31, 2024

I found that the projection_type only supports the following six parameters in Isaac Sim GUI.
Screenshot from 2024-10-31 23-29-10

@RandomOakForest
Copy link
Collaborator

Thank you for submitting this. Will close this issue as there is a PR for this now. Thanks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants