Added --install step before verification #116
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Mayankm96
approved these changes
Sep 25, 2023
Mayankm96
added a commit
that referenced
this pull request
Sep 26, 2023
Co-authored-by: Mayank Mittal <[email protected]>
Mayankm96
added a commit
that referenced
this pull request
Oct 4, 2023
# Description This MR introduces a new set of asset interfaces. These interfaces simplify the spawning of assets into the scene and initializing the physics handle by hiding that into post-startup physics callbacks. Essentially, users no longer need to worry about the `spawn()` and `initialize()` calls themselves. The only interface they need to work with are the configuration objects. This makes the code more flexible and usable. The assets use the following conventions for function names: * `set_xxx()`: this implies that values are set into data buffers (but not into the simulator) * `write_xxx_to_sim()`: writes data into the simulator * `update()`: update all data from the simulator The above isn't an "ideal" function naming since there is no duality of functions (a write has a read method, or a setter has a getter). But I think they convey their functionality clearly from the naming. All data is accessible only through the `data` class for the asset. As a side note, the MR also renames all "dof" to "joint" to make it consistent with the terminology in robotics. ## Type of change <!-- As you go through the list, delete the ones that are not applicable. --> - New feature (non-breaking change which adds functionality) - Breaking change (fix or feature that would cause existing functionality to not work as expected) - This change requires a documentation update ## Checklist - [x] I have run the [`pre-commit` checks](https://pre-commit.com/) with `./orbit.sh --format` - [ ] I have made corresponding changes to the documentation - [ ] My changes generate no new warnings - [ ] I have added tests that prove my fix is effective or that my feature works - [x] I have updated the changelog and the corresponding version in the extension's `config/extension.toml` file --------- Signed-off-by: Mayank Mittal <[email protected]> Co-authored-by: Pascal Roth <[email protected]> Co-authored-by: jsmith-bdai <[email protected]>
Mayankm96
added a commit
that referenced
this pull request
Dec 22, 2023
# Description This MR introduces a new set of asset interfaces. These interfaces simplify the spawning of assets into the scene and initializing the physics handle by hiding that into post-startup physics callbacks. Essentially, users no longer need to worry about the `spawn()` and `initialize()` calls themselves. The only interface they need to work with are the configuration objects. This makes the code more flexible and usable. The assets use the following conventions for function names: * `set_xxx()`: this implies that values are set into data buffers (but not into the simulator) * `write_xxx_to_sim()`: writes data into the simulator * `update()`: update all data from the simulator The above isn't an "ideal" function naming since there is no duality of functions (a write has a read method, or a setter has a getter). But I think they convey their functionality clearly from the naming. All data is accessible only through the `data` class for the asset. As a side note, the MR also renames all "dof" to "joint" to make it consistent with the terminology in robotics. ## Type of change <!-- As you go through the list, delete the ones that are not applicable. --> - New feature (non-breaking change which adds functionality) - Breaking change (fix or feature that would cause existing functionality to not work as expected) - This change requires a documentation update ## Checklist - [x] I have run the [`pre-commit` checks](https://pre-commit.com/) with `./orbit.sh --format` - [ ] I have made corresponding changes to the documentation - [ ] My changes generate no new warnings - [ ] I have added tests that prove my fix is effective or that my feature works - [x] I have updated the changelog and the corresponding version in the extension's `config/extension.toml` file --------- Signed-off-by: Mayank Mittal <[email protected]> Co-authored-by: Pascal Roth <[email protected]> Co-authored-by: jsmith-bdai <[email protected]>
Dhoeller19
pushed a commit
that referenced
this pull request
Sep 20, 2024
# Description
This PR removes the `rsl_rl` agent configs from multi-agent tasks so
avoid the following known issue:
```
Error executing job with overrides: []
Traceback (most recent call last):
File "/home/horde/IsaacLab-Internal/source/extensions/omni.isaac.lab_tasks/omni/isaac/lab_tasks/utils/hydra.py", line 91, in hydra_main
func(env_cfg, agent_cfg, *args, **kwargs)
File "/home/horde/IsaacLab-Internal/source/standalone/workflows/rsl_rl/train.py", line 117, in main
runner = OnPolicyRunner(env, agent_cfg.to_dict(), log_dir=log_dir, device=agent_cfg.device)
File "/home/horde/miniconda/envs/isaaclab/lib/python3.10/site-packages/rsl_rl/runners/on_policy_runner.py", line 29, in __init__
obs, extras = self.env.get_observations()
File "/home/horde/IsaacLab-Internal/source/extensions/omni.isaac.lab_tasks/omni/isaac/lab_tasks/utils/wrappers/rsl_rl/vecenv_wrapper.py", line 145, in get_observations
obs_dict = self.unwrapped._get_observations()
File "/home/horde/IsaacLab-Internal/source/extensions/omni.isaac.lab/omni/isaac/lab/envs/direct_rl_env.py", line 580, in _get_observations
raise NotImplementedError(f"Please implement the '_get_observations' method for {self.__class__.__name__}.")
NotImplementedError: Please implement the '_get_observations' method for Env.
```
## Type of change
- Bug fix (non-breaking change which fixes an issue)
- This change requires a documentation update
## Checklist
- [x] I have run the [`pre-commit` checks](https://pre-commit.com/) with
`./isaaclab.sh --format`
- [x] I have made corresponding changes to the documentation
- [x] My changes generate no new warnings
- [ ] I have added tests that prove my fix is effective or that my
feature works
- [x] I have updated the changelog and the corresponding version in the
extension's `config/extension.toml` file
- [x] I have added my name to the `CONTRIBUTORS.md` or my name already
exists there
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Added extra installation instructions to install orbit. This was report in #93
Type of change
Screenshots
Checklist
pre-commitchecks with./orbit.sh --formatconfig/extension.tomlfile