-
Notifications
You must be signed in to change notification settings - Fork 915
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Proposal] Changing installation instructions #93
Labels
documentation
Improvements or additions to documentation
Comments
Ah yes. That makes sense. Will fix this up in the documentation. |
Mayankm96
added a commit
that referenced
this issue
Aug 2, 2023
# Description This MR merges all the refactorings done to make the legged locomotion environment training work. It includes the following: * `ActionManager` class: To handle various action terms and provide flexibility for HRL. * Actuator simplification: We no longer have actuator groups. All that is handled externally to the robot. * Sensor optimization: Lazy sensor updates (only updated when `data` is called) * Update to new RSL-RL library * TerrainImporter: It does import on initialization instead of expecting input from users. This MR breaks the behavior of the following (many of which need to be fixed): * `RobotBase` : Now there are two methods `write_commands_to_sim` and `refresh_sim_data` that dictate sim read/write. * `ActuatorGroups`: Doesn't exist anymore. * `SensorBase`: Drop for the support of different backends (was not supported earlier but now more explicit) Fixes #37 , #36 ## Type of change - Bug fix (non-breaking change which fixes an issue) - New feature (non-breaking change which adds functionality) - Breaking change (fix or feature that would cause existing functionality to not work as expected) - This change requires a documentation update ## Checklist - [x] I have run the [`pre-commit` checks](https://pre-commit.com/) with `./orbit.sh --format` - [ ] I have made corresponding changes to the documentation - [ ] My changes generate no new warnings - [ ] I have added tests that prove my fix is effective or that my feature works - [x] I have updated the changelog and the corresponding version in the extension's `config/extension.toml` file --------- Co-authored-by: David Hoeller <[email protected]> Co-authored-by: Nikita Rudin <[email protected]> Co-authored-by: Farbod Farshidian <[email protected]>
5 tasks
Mayankm96
added a commit
that referenced
this issue
Dec 22, 2023
# Description This MR merges all the refactorings done to make the legged locomotion environment training work. It includes the following: * `ActionManager` class: To handle various action terms and provide flexibility for HRL. * Actuator simplification: We no longer have actuator groups. All that is handled externally to the robot. * Sensor optimization: Lazy sensor updates (only updated when `data` is called) * Update to new RSL-RL library * TerrainImporter: It does import on initialization instead of expecting input from users. This MR breaks the behavior of the following (many of which need to be fixed): * `RobotBase` : Now there are two methods `write_commands_to_sim` and `refresh_sim_data` that dictate sim read/write. * `ActuatorGroups`: Doesn't exist anymore. * `SensorBase`: Drop for the support of different backends (was not supported earlier but now more explicit) Fixes #37 , #36 ## Type of change - Bug fix (non-breaking change which fixes an issue) - New feature (non-breaking change which adds functionality) - Breaking change (fix or feature that would cause existing functionality to not work as expected) - This change requires a documentation update ## Checklist - [x] I have run the [`pre-commit` checks](https://pre-commit.com/) with `./orbit.sh --format` - [ ] I have made corresponding changes to the documentation - [ ] My changes generate no new warnings - [ ] I have added tests that prove my fix is effective or that my feature works - [x] I have updated the changelog and the corresponding version in the extension's `config/extension.toml` file --------- Co-authored-by: David Hoeller <[email protected]> Co-authored-by: Nikita Rudin <[email protected]> Co-authored-by: Farbod Farshidian <[email protected]>
kellyguo11
pushed a commit
to kellyguo11/IsaacLab-public
that referenced
this issue
Aug 21, 2024
# Description This PR adds the interface and configuration for creating multi-agent tasks using the direct workflow. ## Type of change <!-- As you go through the list, delete the ones that are not applicable. --> - New feature (non-breaking change which adds functionality) - This change requires a documentation update ## Checklist - [x] I have run the [`pre-commit` checks](https://pre-commit.com/) with `./isaaclab.sh --format` - [x] I have made corresponding changes to the documentation - [ ] My changes generate no new warnings - [x] I have added tests that prove my fix is effective or that my feature works - [x] I have updated the changelog and the corresponding version in the extension's `config/extension.toml` file - [x] I have added my name to the `CONTRIBUTORS.md` or my name already exists there <!-- As you go through the checklist above, you can mark something as done by putting an x character in it For example, - [x] I have done this task - [ ] I have not done this task -->
kellyguo11
pushed a commit
to kellyguo11/IsaacLab-public
that referenced
this issue
Aug 21, 2024
This PR adds the interface and configuration for creating multi-agent tasks using the direct workflow. <!-- As you go through the list, delete the ones that are not applicable. --> - New feature (non-breaking change which adds functionality) - This change requires a documentation update - [x] I have run the [`pre-commit` checks](https://pre-commit.com/) with `./isaaclab.sh --format` - [x] I have made corresponding changes to the documentation - [ ] My changes generate no new warnings - [x] I have added tests that prove my fix is effective or that my feature works - [x] I have updated the changelog and the corresponding version in the extension's `config/extension.toml` file - [x] I have added my name to the `CONTRIBUTORS.md` or my name already exists there <!-- As you go through the checklist above, you can mark something as done by putting an x character in it For example, - [x] I have done this task - [ ] I have not done this task -->
kellyguo11
pushed a commit
to kellyguo11/IsaacLab-public
that referenced
this issue
Aug 21, 2024
This PR adds the interface and configuration for creating multi-agent tasks using the direct workflow. <!-- As you go through the list, delete the ones that are not applicable. --> - New feature (non-breaking change which adds functionality) - This change requires a documentation update - [x] I have run the [`pre-commit` checks](https://pre-commit.com/) with `./isaaclab.sh --format` - [x] I have made corresponding changes to the documentation - [ ] My changes generate no new warnings - [x] I have added tests that prove my fix is effective or that my feature works - [x] I have updated the changelog and the corresponding version in the extension's `config/extension.toml` file - [x] I have added my name to the `CONTRIBUTORS.md` or my name already exists there <!-- As you go through the checklist above, you can mark something as done by putting an x character in it For example, - [x] I have done this task - [ ] I have not done this task -->
Dhoeller19
pushed a commit
that referenced
this issue
Sep 20, 2024
This PR adds the interface and configuration for creating multi-agent tasks using the direct workflow. <!-- As you go through the list, delete the ones that are not applicable. --> - New feature (non-breaking change which adds functionality) - This change requires a documentation update - [x] I have run the [`pre-commit` checks](https://pre-commit.com/) with `./isaaclab.sh --format` - [x] I have made corresponding changes to the documentation - [ ] My changes generate no new warnings - [x] I have added tests that prove my fix is effective or that my feature works - [x] I have updated the changelog and the corresponding version in the extension's `config/extension.toml` file - [x] I have added my name to the `CONTRIBUTORS.md` or my name already exists there <!-- As you go through the checklist above, you can mark something as done by putting an x character in it For example, - [x] I have done this task - [ ] I have not done this task -->
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Proposal
Install before testing installation in documentation
Motivation
The installation instructions ask the user to test
python -c "import omni.isaac.orbit; print('Orbit configuration is now complete.')"
before installing with./orbit.sh --install
, which will fail withModuleNotFoundError: No module named 'omni.isaac.orbit'
.Pitch
The order should be swapped?
Checklist
The text was updated successfully, but these errors were encountered: