Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix added #39

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

manishbansal8843
Copy link

Fix for #38

File output stream is flushed just before remote window size is diminished. This will avoid choking channel piped input stream buffer and session thread will be able to ingest SSH_MSG_CHANNEL_WINDOW_ADJUST.

File output stream is flushed just before remote window size is diminished. This will avoid choking channel piped input stream buffer and session thread will be able to ingest SSH_MSG_CHANNEL_WINDOW_ADJUST.
Copy link

@Hima88888888 Hima88888888 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

__

@j-dimension
Copy link

@manishbansal8843 @Hima88888888 I am using jsch to set up a port forwarding tunnel and then execute REST API requests over it. I see that for larger payloads the client gets "stuck" and seemingly does not receive anything anymore and eventually throws a timeout.

Would the fix in this branch help with this issue as well?

@manishbansal8843
Copy link
Author

@manishbansal8843 @Hima88888888 I am using jsch to set up a port forwarding tunnel and then execute REST API requests over it. I see that for larger payloads the client gets "stuck" and seemingly does not receive anything anymore and eventually throws a timeout.

Would the fix in this branch help with this issue as well?

I think so. This seems to be the same issue. I would encourage you to try that. However, few people have reported that this fix did not work for them and i did not get a chance to further debug. But this fix has been working for me from last 1 year in production.

@j-dimension
Copy link

I think so. This seems to be the same issue. I would encourage you to try that. However, few people have reported that this fix did not work for them and i did not get a chance to further debug. But this fix has been working for me from last 1 year in production.

Thanks @manishbansal8843 , will give it a try.

@andreasrosdal
Copy link

Please submit this pull-request here: https://github.com/andreasrosdal/sschlib

norrisjeremy added a commit to norrisjeremy/jsch that referenced this pull request Nov 13, 2023
…n to allow disabling in case it causes regressions.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants