Issue with the proposed fix

[manishbansal8843]

I am glad i am not the first one to face this issue but this did gave me little cry. Anyway, i also did the good amount of analysis and i am glad our views match. However the solution proposed by you looks brittle and will only delay the issue but won't solve it

I feel there could be below 2 reasons for this issue to occur.

1. Sftp network is slow.
2. The client machine does not have enough resources due to which it cannot prioritize the session thread.
   Due to any of the above reasons, it might happen that there is no data for piped input stream to read and hence it straight goes to session.write method waiting for window to get resized.
   Now in this case, even if you increase input buffer, it might fill eventually.

I feel it would be better if the file writing thread should simply wait for the acknowledgements from remote sftp once the remote window is diminished. This way it will make sure that once it goes for waiting rw resizing message, input buffer will never fill no matter what size it has.
What do you think?

[manishbansal8843]

is/jsch#39

Here is the pr link for your reference.

[jlentini]

Hi @manishbansal8843, I'm glad that you found my Jsch analysis useful.

I'm not following your reasoning about a deficiency with my solution. If you have a test case that demonstrates the problem you're describing, I would be happy to look at it.