-
Notifications
You must be signed in to change notification settings - Fork 632
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[tuner]: two new utility functions which are more friendly for c binding #19199
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Bangtian Liu <[email protected]>
bangtianliu
requested review from
MaheshRavishankar,
qedawkins,
kuhar and
Groverkss
as code owners
November 19, 2024 07:40
kuhar
reviewed
Nov 19, 2024
13 tasks
Signed-off-by: Bangtian Liu <[email protected]>
kuhar
approved these changes
Nov 19, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM % one nit
compiler/src/iree/compiler/Codegen/LLVMGPU/TestLLVMGPUQueryMMAPass.cpp
Outdated
Show resolved
Hide resolved
Signed-off-by: Bangtian Liu <[email protected]>
bangtianliu
changed the title
[tuner] two new utility functions which are more friendly for c binding
[tuner]: two new utility functions which are more friendly for c binding
Nov 19, 2024
bangtianliu
added a commit
that referenced
this pull request
Nov 20, 2024
After this PR: #19199 add Python bindings to these two utility functions to querying mma intrinsic instructions from input module. --------- Signed-off-by: Bangtian Liu <[email protected]>
Groverkss
pushed a commit
to Groverkss/iree
that referenced
this pull request
Dec 1, 2024
…ng (iree-org#19199) Follow-up PR after iree-org#19124. TODO: add binding in this PR. --------- Signed-off-by: Bangtian Liu <[email protected]>
Groverkss
pushed a commit
to Groverkss/iree
that referenced
this pull request
Dec 1, 2024
) After this PR: iree-org#19199 add Python bindings to these two utility functions to querying mma intrinsic instructions from input module. --------- Signed-off-by: Bangtian Liu <[email protected]>
giacs-epic
pushed a commit
to giacs-epic/iree
that referenced
this pull request
Dec 4, 2024
…ng (iree-org#19199) Follow-up PR after iree-org#19124. TODO: add binding in this PR. --------- Signed-off-by: Bangtian Liu <[email protected]> Signed-off-by: Giacomo Serafini <[email protected]>
giacs-epic
pushed a commit
to giacs-epic/iree
that referenced
this pull request
Dec 4, 2024
) After this PR: iree-org#19199 add Python bindings to these two utility functions to querying mma intrinsic instructions from input module. --------- Signed-off-by: Bangtian Liu <[email protected]> Signed-off-by: Giacomo Serafini <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow-up PR after #19124.
TODO: add binding in this PR.