-
Notifications
You must be signed in to change notification settings - Fork 632
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[tuner]: add c/python binding for querying mma intrinsic #19218
Conversation
Signed-off-by: Bangtian Liu <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice. Looks good, just need to clean up the code a bit.
Let's keep the test around for now to make sure it continues working as we iterate on this code, but I think we should drop it before landing.
compiler/src/iree/compiler/API/Internal/IREECodegenDialectCAPI.cpp
Outdated
Show resolved
Hide resolved
compiler/src/iree/compiler/API/Internal/IREECodegenDialectCAPI.cpp
Outdated
Show resolved
Hide resolved
compiler/src/iree/compiler/API/Internal/IREECodegenDialectCAPI.cpp
Outdated
Show resolved
Hide resolved
bazel build failed -- we need to add missing build deps to appease it |
Signed-off-by: Bangtian Liu <[email protected]>
Signed-off-by: Bangtian Liu <[email protected]>
compiler/src/iree/compiler/API/Internal/IREECodegenDialectCAPI.cpp
Outdated
Show resolved
Hide resolved
Signed-off-by: Bangtian Liu <[email protected]>
compiler/src/iree/compiler/API/Internal/IREECodegenDialectCAPI.cpp
Outdated
Show resolved
Hide resolved
Signed-off-by: Bangtian Liu <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Have you checked locally that your previous python test still works?
Yes. |
) After this PR: iree-org#19199 add Python bindings to these two utility functions to querying mma intrinsic instructions from input module. --------- Signed-off-by: Bangtian Liu <[email protected]>
) After this PR: iree-org#19199 add Python bindings to these two utility functions to querying mma intrinsic instructions from input module. --------- Signed-off-by: Bangtian Liu <[email protected]> Signed-off-by: Giacomo Serafini <[email protected]>
After this PR: #19199
add Python bindings to these two utility functions to querying mma intrinsic instructions from input module.