Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[tuner]: add c/python binding for querying mma intrinsic #19218

Merged
merged 5 commits into from
Nov 20, 2024

Conversation

bangtianliu
Copy link
Contributor

After this PR: #19199

add Python bindings to these two utility functions to querying mma intrinsic instructions from input module.

Copy link
Member

@kuhar kuhar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice. Looks good, just need to clean up the code a bit.

Let's keep the test around for now to make sure it continues working as we iterate on this code, but I think we should drop it before landing.

compiler/bindings/c/iree/compiler/dialects/iree_codegen.h Outdated Show resolved Hide resolved
compiler/bindings/c/iree/compiler/dialects/iree_codegen.h Outdated Show resolved Hide resolved
compiler/bindings/python/IREECompilerDialectsModule.cpp Outdated Show resolved Hide resolved
compiler/bindings/python/IREECompilerDialectsModule.cpp Outdated Show resolved Hide resolved
compiler/bindings/python/IREECompilerDialectsModule.cpp Outdated Show resolved Hide resolved
@kuhar
Copy link
Member

kuhar commented Nov 20, 2024

bazel build failed -- we need to add missing build deps to appease it

Signed-off-by: Bangtian Liu <[email protected]>
@bangtianliu bangtianliu requested a review from kuhar November 20, 2024 23:20
Copy link
Member

@kuhar kuhar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Have you checked locally that your previous python test still works?

@bangtianliu
Copy link
Contributor Author

LGTM. Have you checked locally that your previous python test still works?

Yes.

@bangtianliu bangtianliu merged commit e1ce3fa into iree-org:main Nov 20, 2024
36 checks passed
Groverkss pushed a commit to Groverkss/iree that referenced this pull request Dec 1, 2024
)

After this PR: iree-org#19199

add Python bindings to these two utility functions to querying mma
intrinsic instructions from input module.

---------

Signed-off-by: Bangtian Liu <[email protected]>
giacs-epic pushed a commit to giacs-epic/iree that referenced this pull request Dec 4, 2024
)

After this PR: iree-org#19199

add Python bindings to these two utility functions to querying mma
intrinsic instructions from input module.

---------

Signed-off-by: Bangtian Liu <[email protected]>
Signed-off-by: Giacomo Serafini <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants