[StableHLO][CHLO] Port CHLO decomposition patterns #13838
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
These are ported from the mlir-hlo project. For more context, see the initial import: iree-org#12957. The biggest difference it the removal of most FileCheck CHECK lines in tests. MHLO hardcoded thousands lines of exact decomposition sequences that fell apart after due to different canonicalizations and folds. Without a script to regenerate these CHECKs, these tests were not maintanable and I decided to drop them. Now we only check that the dialect conversion succeeded. Other notable differences to the MHLO implementation: - Ported some utility functions and tablegen defs. - New `chlo.tan` lowering, since StableHLO does not provide a tan op. Issue: iree-org#13803
antiagainst
approved these changes
May 30, 2023
jvstokes
pushed a commit
to jvstokes/iree
that referenced
this pull request
Jun 4, 2023
These are ported from the mlir-hlo project. For more context, see the initial import: iree-org#12957. The biggest difference it the removal of most FileCheck CHECK lines in tests. MHLO hardcoded thousands lines of exact decomposition sequences that fell apart after due to different canonicalizations and folds. Without a script to regenerate these CHECKs, these tests were not maintainable and I decided to drop them. Now we only check that the dialect conversion succeeded. Other notable differences to the MHLO implementation: - Ported some utility functions and tablegen defs. - New `chlo.tan` lowering, since StableHLO does not provide a tan op. Issue: iree-org#13803
NatashaKnk
pushed a commit
to NatashaKnk/iree
that referenced
this pull request
Jul 6, 2023
These are ported from the mlir-hlo project. For more context, see the initial import: iree-org#12957. The biggest difference it the removal of most FileCheck CHECK lines in tests. MHLO hardcoded thousands lines of exact decomposition sequences that fell apart after due to different canonicalizations and folds. Without a script to regenerate these CHECKs, these tests were not maintainable and I decided to drop them. Now we only check that the dialect conversion succeeded. Other notable differences to the MHLO implementation: - Ported some utility functions and tablegen defs. - New `chlo.tan` lowering, since StableHLO does not provide a tan op. Issue: iree-org#13803
nhasabni
pushed a commit
to plaidml/iree
that referenced
this pull request
Aug 24, 2023
These are ported from the mlir-hlo project. For more context, see the initial import: iree-org#12957. The biggest difference it the removal of most FileCheck CHECK lines in tests. MHLO hardcoded thousands lines of exact decomposition sequences that fell apart after due to different canonicalizations and folds. Without a script to regenerate these CHECKs, these tests were not maintainable and I decided to drop them. Now we only check that the dialect conversion succeeded. Other notable differences to the MHLO implementation: - Ported some utility functions and tablegen defs. - New `chlo.tan` lowering, since StableHLO does not provide a tan op. Issue: iree-org#13803
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These are ported from the mlir-hlo project. For more context, see the initial import: #12957.
The biggest difference it the removal of most FileCheck CHECK lines in tests. MHLO hardcoded thousands lines of exact decomposition sequences that fell apart after due to different canonicalizations and folds. Without a script to regenerate these CHECKs, these tests were not maintainable and I decided to drop them. Now we only check that the dialect conversion succeeded.
Other notable differences to the MHLO implementation:
chlo.tanlowering, since StableHLO does not provide a tan op.Issue: #13803