Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[StableHLO] Add CHLO op support #13803

Closed
kuhar opened this issue May 26, 2023 · 0 comments · Fixed by #13849
Closed

[StableHLO] Add CHLO op support #13803

kuhar opened this issue May 26, 2023 · 0 comments · Fixed by #13849
Assignees
@kuhar
Labels
enhancement ➕ New feature or request integrations/stablehlo StableHLO (JAX/TensorFlow/etc) import and conversion

Comments

@kuhar
Copy link
Member

kuhar commented May 26, 2023

Request description

CHLO is one of the dialects that can coexist with StableHLO, per https://github.com/openxla/stablehlo/blob/main/docs/spec.md:

At the moment, StableHLO programs in the wild sometimes contain operations that are not described in this document. In the future, we are planning to either absorb these operations into the StableHLO opset or prohibit them from appearing in StableHLO programs. In the meanwhile, here is the list of these operations:

We need to support them in the IREE StableHLO input conversion pipeline (--iree-input-type=stablehlo).

What component(s) does this issue relate to?

Frontends

Additional context

Parent issue: #12678
@kuhar kuhar added enhancement ➕ New feature or request integrations/stablehlo StableHLO (JAX/TensorFlow/etc) import and conversion labels May 26, 2023
@kuhar kuhar self-assigned this May 26, 2023
@kuhar kuhar moved this from Inbox to In Progress in (Deprecated) IREE May 26, 2023
@kuhar kuhar mentioned this issue May 26, 2023
Closed
kuhar added a commit to kuhar/iree that referenced this issue May 26, 2023
@kuhar
[StableHLO][CHLO] Port initial CHLO lowering patterns
0ee4069 
The implementation is ported from the mlir-hlo project. For more context,
see the initial import: iree-org#12957.

This also required porting over some canonicalization patterns for
`stablehlo.dynamic_broadcast_in_dim`.

Issue: iree-org#13803
@kuhar kuhar mentioned this issue May 26, 2023
Merged
kuhar added a commit that referenced this issue May 26, 2023
@kuhar
[StableHLO][CHLO] Port initial CHLO lowering patterns (#13819)
851126b 
The implementation is ported from the mlir-hlo project. For more
context, see the initial import:
#12957.

This also required porting over some canonicalization patterns for
`stablehlo.dynamic_broadcast_in_dim`.

Issue: #13803
kuhar added a commit to kuhar/iree that referenced this issue May 29, 2023
@kuhar
[StableHLO][CHLO] Add CHLO to stablehlo pipeline
203621c 
Unlike in the MHLO pipeline, run CHLO legalization as a separate pass to
better controll required canonicalization patterns. This also decouples
the CHLO conversion from the custom type converter used during lowering
to linalg and IREE dialects.

Also add a pattern to handle non-broadcasting constants.

Issue: iree-org#13803
@kuhar kuhar mentioned this issue May 29, 2023
Merged
kuhar added a commit to kuhar/iree that referenced this issue May 29, 2023
@kuhar
[StableHLO][CHLO][NFC] Add broadcasting tests
6429ee3 
Issue: iree-org#13803
@kuhar kuhar mentioned this issue May 29, 2023
Merged
kuhar added a commit that referenced this issue May 29, 2023
@kuhar
[StableHLO][CHLO][NFC] Add broadcasting tests (#13836)
4c2c575 
Issue: #13803
kuhar added a commit that referenced this issue May 29, 2023
@kuhar
[StableHLO][CHLO] Add CHLO to stablehlo pipeline (#13835)
b218383 
Unlike in the MHLO pipeline, run CHLO legalization as a separate pass to
better controll required canonicalization patterns. This also decouples
the CHLO conversion from the custom type converter used during lowering
to linalg and IREE dialects.

Also add a pattern to handle non-broadcasting constants.

Issue: #13803
kuhar added a commit to kuhar/iree that referenced this issue May 30, 2023
@kuhar
[StableHLO][CHLO] Port CHLO decomposition patterns
a7bee2c 
These are ported from the mlir-hlo project. For more context, see the
initial import: iree-org#12957.

The biggest difference it the removal of most FileCheck CHECK lines in
tests. MHLO hardcoded thousands lines of exact decomposition sequences
that fell apart after due to different canonicalizations and folds.
Without a script to regenerate these CHECKs, these tests were not
maintanable and I decided to drop them. Now we only check that the
dialect conversion succeeded.

Other notable differences to the MHLO implementation:
-  Ported some utility functions and tablegen defs.
-  New `chlo.tan` lowering, since StableHLO does not provide a tan op.

Issue: iree-org#13803
@kuhar kuhar mentioned this issue May 30, 2023
Merged
kuhar added a commit that referenced this issue May 30, 2023
@kuhar
[StableHLO][CHLO] Port CHLO decomposition patterns (#13838)
8c41e51 
These are ported from the mlir-hlo project. For more context, see the
initial import: #12957.

The biggest difference it the removal of most FileCheck CHECK lines in
tests. MHLO hardcoded thousands lines of exact decomposition sequences
that fell apart after due to different canonicalizations and folds.
Without a script to regenerate these CHECKs, these tests were not
maintainable and I decided to drop them. Now we only check that the
dialect conversion succeeded.

Other notable differences to the MHLO implementation:
-  Ported some utility functions and tablegen defs.
-  New `chlo.tan` lowering, since StableHLO does not provide a tan op.

Issue: #13803
kuhar added a commit to kuhar/iree that referenced this issue May 30, 2023
@kuhar
[StableHLO][CHLO][NFC] Clarify where CHLO happens
da8a16f 
Only some of the lowering passes deal with CHLO ops.

Fixes: iree-org#13803
@kuhar kuhar mentioned this issue May 30, 2023
Merged
kuhar added a commit that referenced this issue May 30, 2023
@kuhar
[StableHLO][CHLO][NFC] Clarify where CHLO lowering happens (#13849)
f356ff2 
Only some of the lowering passes deal with CHLO ops.

Fixes: #13803
@github-project-automation github-project-automation bot moved this from In Progress to Done in (Deprecated) IREE May 30, 2023
jvstokes pushed a commit to jvstokes/iree that referenced this issue Jun 4, 2023
@kuhar @jvstokes
[StableHLO][CHLO][NFC] Add broadcasting tests (iree-org#13836)
a555354 
Issue: iree-org#13803
jvstokes pushed a commit to jvstokes/iree that referenced this issue Jun 4, 2023
@kuhar @jvstokes
[StableHLO][CHLO] Add CHLO to stablehlo pipeline (iree-org#13835)
3f5e3b7 
Unlike in the MHLO pipeline, run CHLO legalization as a separate pass to
better controll required canonicalization patterns. This also decouples
the CHLO conversion from the custom type converter used during lowering
to linalg and IREE dialects.

Also add a pattern to handle non-broadcasting constants.

Issue: iree-org#13803
jvstokes pushed a commit to jvstokes/iree that referenced this issue Jun 4, 2023
@kuhar @jvstokes
[StableHLO][CHLO] Port CHLO decomposition patterns (iree-org#13838)
45a8a86 
These are ported from the mlir-hlo project. For more context, see the
initial import: iree-org#12957.

The biggest difference it the removal of most FileCheck CHECK lines in
tests. MHLO hardcoded thousands lines of exact decomposition sequences
that fell apart after due to different canonicalizations and folds.
Without a script to regenerate these CHECKs, these tests were not
maintainable and I decided to drop them. Now we only check that the
dialect conversion succeeded.

Other notable differences to the MHLO implementation:
-  Ported some utility functions and tablegen defs.
-  New `chlo.tan` lowering, since StableHLO does not provide a tan op.

Issue: iree-org#13803
jvstokes pushed a commit to jvstokes/iree that referenced this issue Jun 4, 2023
@kuhar @jvstokes
[StableHLO][CHLO][NFC] Clarify where CHLO lowering happens (iree-org#…
5ba36a5 
…13849)

Only some of the lowering passes deal with CHLO ops.

Fixes: iree-org#13803
NatashaKnk pushed a commit to NatashaKnk/iree that referenced this issue Jul 6, 2023
@kuhar @NatashaKnk
[StableHLO][CHLO] Port initial CHLO lowering patterns (iree-org#13819)
23a84a9 
The implementation is ported from the mlir-hlo project. For more
context, see the initial import:
iree-org#12957.

This also required porting over some canonicalization patterns for
`stablehlo.dynamic_broadcast_in_dim`.

Issue: iree-org#13803
NatashaKnk pushed a commit to NatashaKnk/iree that referenced this issue Jul 6, 2023
@kuhar @NatashaKnk
[StableHLO][CHLO][NFC] Add broadcasting tests (iree-org#13836)
5b0830c 
Issue: iree-org#13803
NatashaKnk pushed a commit to NatashaKnk/iree that referenced this issue Jul 6, 2023
@kuhar @NatashaKnk
[StableHLO][CHLO] Add CHLO to stablehlo pipeline (iree-org#13835)
2463d99 
Unlike in the MHLO pipeline, run CHLO legalization as a separate pass to
better controll required canonicalization patterns. This also decouples
the CHLO conversion from the custom type converter used during lowering
to linalg and IREE dialects.

Also add a pattern to handle non-broadcasting constants.

Issue: iree-org#13803
NatashaKnk pushed a commit to NatashaKnk/iree that referenced this issue Jul 6, 2023
@kuhar @NatashaKnk
[StableHLO][CHLO] Port CHLO decomposition patterns (iree-org#13838)
2a449d5 
These are ported from the mlir-hlo project. For more context, see the
initial import: iree-org#12957.

The biggest difference it the removal of most FileCheck CHECK lines in
tests. MHLO hardcoded thousands lines of exact decomposition sequences
that fell apart after due to different canonicalizations and folds.
Without a script to regenerate these CHECKs, these tests were not
maintainable and I decided to drop them. Now we only check that the
dialect conversion succeeded.

Other notable differences to the MHLO implementation:
-  Ported some utility functions and tablegen defs.
-  New `chlo.tan` lowering, since StableHLO does not provide a tan op.

Issue: iree-org#13803
NatashaKnk pushed a commit to NatashaKnk/iree that referenced this issue Jul 6, 2023
@kuhar @NatashaKnk
[StableHLO][CHLO][NFC] Clarify where CHLO lowering happens (iree-org#…
61c4fa3 
…13849)

Only some of the lowering passes deal with CHLO ops.

Fixes: iree-org#13803
nhasabni pushed a commit to plaidml/iree that referenced this issue Aug 24, 2023
@kuhar @nhasabni
[StableHLO][CHLO] Port initial CHLO lowering patterns (iree-org#13819)
2ac7185 
The implementation is ported from the mlir-hlo project. For more
context, see the initial import:
iree-org#12957.

This also required porting over some canonicalization patterns for
`stablehlo.dynamic_broadcast_in_dim`.

Issue: iree-org#13803
nhasabni pushed a commit to plaidml/iree that referenced this issue Aug 24, 2023
@kuhar @nhasabni
[StableHLO][CHLO][NFC] Add broadcasting tests (iree-org#13836)
5d41053 
Issue: iree-org#13803
nhasabni pushed a commit to plaidml/iree that referenced this issue Aug 24, 2023
@kuhar @nhasabni
[StableHLO][CHLO] Add CHLO to stablehlo pipeline (iree-org#13835)
a701a6a 
Unlike in the MHLO pipeline, run CHLO legalization as a separate pass to
better controll required canonicalization patterns. This also decouples
the CHLO conversion from the custom type converter used during lowering
to linalg and IREE dialects.

Also add a pattern to handle non-broadcasting constants.

Issue: iree-org#13803
nhasabni pushed a commit to plaidml/iree that referenced this issue Aug 24, 2023
@kuhar @nhasabni
[StableHLO][CHLO] Port CHLO decomposition patterns (iree-org#13838)
f15e295 
These are ported from the mlir-hlo project. For more context, see the
initial import: iree-org#12957.

The biggest difference it the removal of most FileCheck CHECK lines in
tests. MHLO hardcoded thousands lines of exact decomposition sequences
that fell apart after due to different canonicalizations and folds.
Without a script to regenerate these CHECKs, these tests were not
maintainable and I decided to drop them. Now we only check that the
dialect conversion succeeded.

Other notable differences to the MHLO implementation:
-  Ported some utility functions and tablegen defs.
-  New `chlo.tan` lowering, since StableHLO does not provide a tan op.

Issue: iree-org#13803
nhasabni pushed a commit to plaidml/iree that referenced this issue Aug 24, 2023
@kuhar @nhasabni
[StableHLO][CHLO][NFC] Clarify where CHLO lowering happens (iree-org#…
3a0802e 
…13849)

Only some of the lowering passes deal with CHLO ops.

Fixes: iree-org#13803
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@kuhar kuhar

Labels
enhancement ➕ New feature or request integrations/stablehlo StableHLO (JAX/TensorFlow/etc) import and conversion
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[StableHLO][CHLO][NFC] Clarify where CHLO lowering happens kuhar/iree
1 participant
@kuhar