Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix vlan lookup for local vlan defined on neighbor node only #645

Merged
merged 1 commit into from
Nov 11, 2022

Conversation

jbemmel
Copy link
Collaborator

@jbemmel jbemmel commented Nov 10, 2022

Addresses #287

@jbemmel jbemmel marked this pull request as draft November 10, 2022 20:27
@jbemmel jbemmel force-pushed the fix-local-vlan-lookup-in-neighbors branch from 98400d5 to 604cc63 Compare November 10, 2022 20:34
@jbemmel jbemmel marked this pull request as ready for review November 10, 2022 20:36
@jbemmel jbemmel requested a review from ipspace November 10, 2022 20:37
Copy link
Owner

@ipspace ipspace left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wow. Such a lovely and ingenious fix ;)) Thanks a million!

vlan-single-node test case seems to be a duplicate of vlan-access-neighbors test case. If that's true, I'll remove it and amend the commit.

@ipspace ipspace merged commit 140be8b into ipspace:dev Nov 11, 2022
ipspace pushed a commit that referenced this pull request Nov 11, 2022
@jbemmel jbemmel deleted the fix-local-vlan-lookup-in-neighbors branch November 13, 2024 20:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants