Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Incorrect interface neighbor list on single-node VLANs #287

Closed
ipspace opened this issue May 13, 2022 · 1 comment
Closed

Incorrect interface neighbor list on single-node VLANs #287

ipspace opened this issue May 13, 2022 · 1 comment
Labels
bug Something isn't working

Comments

@ipspace
Copy link
Owner

ipspace commented May 13, 2022

The following topology incorrectly calculates neighbors on R1 and R2, resulting in no EBGP session between them.

nodes:
  r1:
    module: [ bgp ]
    bgp.as: 65000
  s1:
    module: [ vlan ]
    vlans:
      red:
  r2:
    module: [ bgp ]
    bgp.as: 65001

links:
- r1:
  s1:
    vlan.access: red
- r2:
  s1:
    vlan.access: red

We should convert single-node VLANs into fake global VLANs (example: vlan@node), and clean them up after the topology transformation.
ipspace added a commit that referenced this issue May 13, 2022
@ipspace
Bug fix: Don't create bogus VLAN data (quick-and-dirty fix for #285)
f78fcb0 
The VLAN module created bogus VLAN entries on nodes with VLAN module
attached as a regular nodes to an access VLAN interface using a single-node
VLAN. For the moment, we just get out of that situation, but that
results in incorrect neighbor list (#287)

Also included: test case for #287.
@ipspace ipspace added the bug Something isn't working label Jun 6, 2022
@jbemmel jbemmel mentioned this issue Nov 10, 2022
Merged
@ipspace
Copy link
Owner Author

ipspace commented Nov 11, 2022

Fixed by 140be8b / a55a60d

@ipspace ipspace closed this as completed Nov 11, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@ipspace