Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix punc-caps issues of cli Tagline #2231

Merged
merged 2 commits into from
Jan 23, 2016
Merged

Fix punc-caps issues of cli Tagline #2231

merged 2 commits into from
Jan 23, 2016

Conversation

rht
Copy link
Contributor

@rht rht commented Jan 21, 2016

No description provided.

@rht rht mentioned this pull request Jan 21, 2016
License: MIT
Signed-off-by: rht <[email protected]>
@rht rht added the topic/docs-ipfs Topic docs-ipfs label Jan 21, 2016
@rht rht changed the title Fix punc-caps issues of cli Tagline [wip] Fix punc-caps issues of cli Tagline Jan 21, 2016
@rht rht added the RFCR label Jan 21, 2016
@@ -24,7 +24,7 @@ type ConfigField struct {

var ConfigCmd = &cmds.Command{
Helptext: cmds.HelpText{
Tagline: "get and set IPFS config values",
Tagline: "get and set IPFS config values.",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Caps on get?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Somehow missed that.
Used regex /Tagline:.*"[[:lower:]]/ to fix them once for all.

@RichardLitt
Copy link
Member

One comment, otherwise LGTM.

@RichardLitt
Copy link
Member

LGTM.

rht added a commit that referenced this pull request Jan 23, 2016
Fix punc-caps issues of cli Tagline
@rht rht merged commit 6cfc00e into ipfs:master Jan 23, 2016
@rht rht deleted the docs/punc-caps branch January 23, 2016 05:52
@whyrusleeping
Copy link
Member

@rht please let either @jbenet or myself merge these.

@jbenet
Copy link
Member

jbenet commented Jan 23, 2016

^

and LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
topic/docs-ipfs Topic docs-ipfs
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants