Fixed up docs for bitswap #2228
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
License: MIT Signed-off-by: Richard Littauer <[email protected]>
| @@ -16,7 +16,7 @@ import ( | |||
|
|
|||
| var BitswapCmd = &cmds.Command{ | |||
| Helptext: cmds.HelpText{ | |||
| Tagline: "A set of commands to manipulate the bitswap agent", | |||
| Tagline: "A set of commands to manipulate the bitswap agent.", | |||
There was a problem hiding this comment.
@RichardLitt if you grep for the entire Tagline:, most of the strings don't have the punctuation.
There was a problem hiding this comment.
nvm, I raised the issue, so here it is #2231
There was a problem hiding this comment.
There are significantly more tagline without '.', but however, cat does have it
Usage: cat [OPTION]... [FILE]...
Concatenate FILE(s) to standard output.
With no FILE, or when FILE is -, read standard input.
-A, --show-all equivalent to -vET
-b, --number-nonblank number nonempty output lines, overrides -n
-e equivalent to -vE
-E, --show-ends display $ at end of each line
-n, --number number all output lines
-s, --squeeze-blank suppress repeated empty output lines
-t equivalent to -vT
-T, --show-tabs display TAB characters as ^I
-u (ignored)
-v, --show-nonprinting use ^ and M- notation, except for LFD and TAB
--help display this help and exit
--version output version information and exit
Examples:
cat f - g Output f's contents, then standard input, then g's contents.
cat Copy standard input to standard output.
GNU coreutils online help: <http://www.gnu.org/software/coreutils/>
Full documentation at: <http://www.gnu.org/software/coreutils/cat>
or available locally via: info '(coreutils) cat invocation'
There was a problem hiding this comment.
Cool. I say we go for it, because we haven't largely out of laziness. #2231 looks good.
|
The scope of this PR is specific to bitswap, therefore LGTM. |
|
(stop @rht soon) |
|
LGTM |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
License: MIT
Signed-off-by: Richard Littauer [email protected]