Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

All markdown #70

Merged
merged 2 commits into from
Jan 20, 2020
Merged

All markdown #70

merged 2 commits into from
Jan 20, 2020

Conversation

edgo914
Copy link
Contributor

@edgo914 edgo914 commented Jan 17, 2020

No description provided.

@johnnymatthews
Copy link
Contributor

@cwaring, I can't tell why this CI build didn't work. Any ideas?

@ipfs ipfs deleted a comment Jan 20, 2020
@ipfs ipfs deleted a comment Jan 20, 2020
@ipfs ipfs deleted a comment Jan 20, 2020
@ipfs ipfs deleted a comment Jan 20, 2020
@ipfs ipfs deleted a comment Jan 20, 2020
@ipfs ipfs deleted a comment Jan 20, 2020
@jessicaschilling jessicaschilling merged commit a71e02d into ipfs:master Jan 20, 2020
@jessicaschilling
Copy link
Contributor

@johnnymatthews -- with how CI is set up, it'll look like PRs coming from contributor forks fail the deploy part of the workflow. That's not actually the case ... you just need to merge yourself (coming from "inside" the CI) in order to actually trigger the deploy part.

Keeping that in mind, I merged this one in. Great work, @edgo914 ... I'll let you and @johnnymatthews discuss bounty reward details and then y'all can close ipfs-inactive/docs#56 😊

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants