Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Work on glossary.md #68

Merged
merged 2 commits into from
Jan 17, 2020
Merged

Work on glossary.md #68

merged 2 commits into from
Jan 17, 2020

Conversation

edgo914
Copy link
Contributor

@edgo914 edgo914 commented Jan 16, 2020

Copy link
Contributor

@johnnymatthews johnnymatthews left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me! Nice work!

@johnnymatthews johnnymatthews self-assigned this Jan 17, 2020
@johnnymatthews johnnymatthews merged commit 6b792e2 into ipfs:master Jan 17, 2020
@cwaring
Copy link
Member

cwaring commented Jan 17, 2020

I had to revert this PR as there are errors that need to be corrected.

All pages need to retain the front-matter data appropriate for the page, a minimum of title and we shouldn't use HTML to reference anchor links. Please change all HTML tags to use valid markdown. e.g.

[[toc]]

## A
### Announcing

## B
### Bitswap

## C
### CBOR

etc

[[toc]] will auto generate a table of contents that will stay in sync as the content changes, see - https://v1.vuepress.vuejs.org/guide/markdown.html#table-of-contents

@edgo914
Copy link
Contributor Author

edgo914 commented Jan 17, 2020 via email

@johnnymatthews
Copy link
Contributor

Is there an example of [[toc]] somewhere already in ipfs docs?

@edgo914 adding a Table of Contents is as simple as adding [[toc]] into your markdown.

vs-code

The above example creates the ToC as seen below.

ipfs-site


"any one entity" meant "any single entity, like a government or
terrorist group" ... not "anyone entity"

My bad, don't know how I missed that one. Ignore my edit then :)

@cwaring
Copy link
Member

cwaring commented Jan 17, 2020

One thing to note is this is only a suggestion if you wish to embed the table of contents in the page itself. With the correct header levels, eg. ## for H2 and ### for H3 the sidebar will be auto populated with the section navigation. In order to disable that you would have to set sidebarDepth: 0 in the header front matter.

I would suggest to use the automatic sidebar navigation over embedding an addition in page ToC unless the sidebar doesn't achieve the desired results. @johnnymatthews it may be best for you to experiment and advise further here.

@edgo914
Copy link
Contributor Author

edgo914 commented Jan 17, 2020 via email

@edgo914
Copy link
Contributor Author

edgo914 commented Jan 17, 2020 via email

@johnnymatthews
Copy link
Contributor

I like it. Things look much cleaner, and the markdown is easier to read. This type of Table of Contents should only be used for this page though. The glossary is a special page that needs this kind of presentation.

Screenshot_2020-01-18 Glossary

I'll merge the PR once the CI build issue is sorted.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants