feat: better handling of 'unresponsive' event #1952
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lidel
requested changes
Jan 21, 2022
| window.webContents.on('unresponsive', event => { | ||
| logger.error(`[web ui] unresponsive: ${event.toString()}`) | ||
| window.webContents.on('unresponsive', () => { | ||
| logger.error('[web ui] the webui became unresponsive') |
There was a problem hiding this comment.
Would it be possible to add a dialog here, where user can decide if they want to kill a rogue webui process before it slows everything down to a crawl for some reason?
Found a poc here (just needs i18n strings):
contents.on('unresponsive', async () => {
const { response } = await dialog.showMessageBox({
message: 'App X has become unresponsive',
title: 'Do you want to try forcefully reloading the app?',
buttons: ['OK', 'Cancel'],
cancelId: 1
})
if (response === 0) {
contents.forcefullyCrashRenderer()
contents.reload()
}
})
lidel
changed the title
hacdias
force-pushed
the
rm-deprecated-crashed
branch
from
d124ca0
to
ee273c5
Compare
electron/electron#23096 License: MIT Signed-off-by: Henrique Dias <[email protected]>
License: MIT Signed-off-by: Henrique Dias <[email protected]>
License: MIT Signed-off-by: Henrique Dias <[email protected]>
License: MIT Signed-off-by: Henrique Dias <[email protected]>
hacdias
force-pushed
the
rm-deprecated-crashed
branch
from
ee273c5
to
c51823e
Compare
dedicated button labels remove any ambiguity
lidel
force-pushed
the
rm-deprecated-crashed
branch
from
d7f9ea7
to
9561bc4
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Replaces the deprecated event 'crashed' by 'render-process-gone' and actually use the information correctly. In addition, I removed the
event.toString()from the 'unresponsive' event because it does not contain additional info.References:
Noticed this because on #1951, the logs just say
[object Object]...License: MIT
Signed-off-by: Henrique Dias [email protected]