Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Recover from unresponsive webui in webContents #1865

Closed
lialosiu opened this issue Jun 30, 2021 · 3 comments
Closed

Recover from unresponsive webui in webContents #1865

lialosiu opened this issue Jun 30, 2021 · 3 comments
Assignees
@hacdias
Labels
effort/hours Estimated to take one or several hours exp/intermediate Prior experience is likely helpful good first issue Good issue for new contributors help wanted Seeking public contribution on this issue P2 Medium: Good to have, but can wait until someone steps up

Comments

@lialosiu
Copy link

lialosiu commented Jun 30, 2021 •
edited
Loading

QmfFLsxJsviSncH5LGkwss53Vn2v6ebZYb3bJYtZ5P25HM

this is the a sample file hash.

browse this file hash will freeze the window, and got high cpu usage.

and the log said: error: [web ui] unresponsive: [object Object]
@lidel lidel added the need/triage Needs initial labeling and prioritization label Jul 6, 2021
@ipfs ipfs deleted a comment from welcome bot Jul 6, 2021
@lidel
Copy link
Member

lidel commented Jul 6, 2021

QmfFLsxJsviSncH5LGkwss53Vn2v6ebZYb3bJYtZ5P25HM has no diallble providers, so UI is stuck at content lookup phase.

Closing this as a duplicate of ipfs/ipfs-webui#1794

@lidel lidel closed this as completed Jul 6, 2021
@lidel
Copy link
Member

lidel commented Jul 6, 2021 •
edited
Loading

Apart from the linked ipfs-webui issue, there is a feature request here:
IPFS Desktop should detect unresponsive webui window and recover from it!

We could listen for unresponsive event:

window.on('unresponsive', () => {
  // destroy webui window and open new one
})

Caveat: there is also responsive when unresponsiveness was a temporary fluke, so we most likely should do reload only when unresponsive is not followed by responsive in some period of time, eg. ~10s

@lidel lidel reopened this Jul 6, 2021
@lidel lidel changed the title app window freeze when preview some file Recover from unresponsive webui in webContents Jul 6, 2021
@lidel lidel added effort/hours Estimated to take one or several hours exp/intermediate Prior experience is likely helpful good first issue Good issue for new contributors help wanted Seeking public contribution on this issue P2 Medium: Good to have, but can wait until someone steps up and removed need/triage Needs initial labeling and prioritization labels Jul 6, 2021
@hacdias hacdias self-assigned this Sep 20, 2021
@hacdias hacdias mentioned this issue Sep 20, 2021
Closed
@lidel
Copy link
Member

lidel commented Feb 8, 2022

Closed by #1952

@lidel lidel closed this as completed Feb 8, 2022
@tinytb tinytb moved this to Done in IP JS (PL EngRes) v2 Oct 14, 2022
@Kirobi92 Kirobi92 mentioned this issue Apr 25, 2023
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@hacdias hacdias

Labels
effort/hours Estimated to take one or several hours exp/intermediate Prior experience is likely helpful good first issue Good issue for new contributors help wanted Seeking public contribution on this issue P2 Medium: Good to have, but can wait until someone steps up
Projects
No open projects
IP JS (PL EngRes) v2
Archived in project
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: detect unresponsiveness and restart window ipfs/ipfs-desktop
3 participants
@lidel @lialosiu @hacdias