feat: opt-in for loading webui from dnslink #738
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This changes the way "Open Web UI" menu option works. Before: we kept CID of latest version and opened it from gateway port + executed a lot of magic to ensure it can talk to api port in secure way. After: we removed all the magic and just open the version provided on api port. Details: #736
Adds an opt-in toggle (disabled by default) to Preferences
which changes the URL of Web UI opened via Browser Action menu
from {API}/webui to {API}/ipns/webui.ipfs.io
This enables user to load the latest webui via DNSLink.
Note that go-ipfs and js-ipfs do not whitelist /ipns/webui.ipfs.io on
the API port yet, so there is a fallback in place that detects HTTP 404
and redirects user to {API}/webui.
Closes: #736
lidel
commented
Jul 18, 2019
| @@ -351,6 +351,14 @@ | |||
| "message": "Turn plaintext /ipfs/ paths into clickable links", | |||
| "description": "An option description on the Preferences screen (option_linkify_description)" | |||
| }, | |||
| "option_webuiFromDNSLink_title": { | |||
| "message": "Load the latest Web UI", | |||
There was a problem hiding this comment.
@olizilla would appreciate your thoughts on how to name and describe this feature.
My initial stab looks like this:
lidel
commented
Jul 18, 2019
| } | ||
| // Recover from a broken DNSLink webui by redirecting back to CID one | ||
| // TODO: remove when both GO and JS ship support for /ipns/webui.ipfs.io on the API port | ||
| if (request.statusCode === 404 && request.url === state.webuiURLString && state.webuiFromDNSLink) { |
There was a problem hiding this comment.
This means we can ship this feature before ipfs/kubo#6530 lands
|
This will be possible to implement in much more elegant way when subdomain gateway lands. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR Adds an opt-in toggle (disabled by default) to Preferences which changes the URL of Web UI opened via Browser Action menu from
{API}/webuito{API}/ipns/webui.ipfs.io:This enables user to load the latest webui via DNSLink.
Note that go-ipfs and js-ipfs do not whitelist
/ipns/webui.ipfs.ioon the API port yet (ipfs/kubo#6530), so there is a fallback in place that detects HTTP 404 and redirects user to{API}/webui.Closes: #736