Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Opt-in for loading latest webui from webui.ipfs.io.ipns.localhost #860

Closed
lidel opened this issue Apr 3, 2020 · 5 comments · Fixed by #893
Closed

Opt-in for loading latest webui from webui.ipfs.io.ipns.localhost #860

lidel opened this issue Apr 3, 2020 · 5 comments · Fixed by #893
Labels
area/webui Issues related to interactions with Web UI effort/days Estimated to take multiple days, but less than a week exp/novice Someone with a little familiarity can pick up good first issue Good issue for new contributors help wanted Seeking public contribution on this issue kind/enhancement A net-new feature or improvement to an existing feature P3 Low: Not priority right now status/deferred Conscious decision to pause or backlog topic/design-ux UX strategy, research, not solely visual design

Comments

@lidel
Copy link
Member

lidel commented Apr 3, 2020 •
edited
Loading

With subdomain gateway on localhost (#853), users who want to use the latest Web UI can add http://webui.ipfs.io.ipns.localhost:8080 to API.HTTPHeaders.Access-Control-Allow-Origin whitelist in go-ipfs config.

Idea: add an opt-in on Preferences screen (could be an experiment)

The toggle would:

  1. append/remove mentioned origin to CORS whitelist in go-ipfs config (if its applied immediately) OR remove Origin header from requests coming from webui.ipfs.io.ipns.localhost:8080 (will disable Origin check at go-ipfs)
  2. swap webuiRootUrl to open webui.ipfs.io.ipns.localhost:8080 instead of 127.0.0.1:5001 (this includes Open WebUI in browser action menu, but also Files screen after successful file import)
@lidel lidel added kind/enhancement A net-new feature or improvement to an existing feature help wanted Seeking public contribution on this issue exp/intermediate Prior experience is likely helpful P3 Low: Not priority right now status/deferred Conscious decision to pause or backlog effort/hours Estimated to take one or several hours area/webui Issues related to interactions with Web UI labels Apr 3, 2020
@lidel lidel mentioned this issue Apr 3, 2020
Closed
@lidel lidel added effort/days Estimated to take multiple days, but less than a week and removed effort/hours Estimated to take one or several hours labels Apr 3, 2020
This was referenced Apr 3, 2020
Closed
Closed
@jessicaschilling jessicaschilling added the topic/design-ux UX strategy, research, not solely visual design label Apr 6, 2020
@jessicaschilling
Copy link
Contributor

jessicaschilling commented Apr 9, 2020 •
edited
Loading

@lidel Suggestion of minor tweak to the text? (except without the automatic GitHub link-making, sigh)
Replaces your node's stable version with the latest at /ipns/webui.ipfs.io (requires working DNS and a compatible back end)

@jessicaschilling
Copy link
Contributor

@lidel are we interested in following up on this one?

@lidel
Copy link
Member Author

lidel commented Jun 4, 2020

Yes, I believe adding a toggle that changes the URL behind menu item is all we need to do here:

That is all.

Companion should not do any hacking around Origin or CORS: WebUI has pretty good instructions for users on how to set up headers now: ipfs/ipfs-webui#1496

@lidel lidel added exp/novice Someone with a little familiarity can pick up good first issue Good issue for new contributors and removed exp/intermediate Prior experience is likely helpful labels Jun 4, 2020
@jessicaschilling
Copy link
Contributor

@lidel Do you have time? ;)

@lidel lidel mentioned this issue Jun 8, 2020
Merged
@lidel
Copy link
Member Author

lidel commented Jun 8, 2020

I was about to reply I don't have bandwidth and started writing tips for someone who would like to pick this up and i accidentaly ended up implementing it 🤦‍♂️ see #893

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
area/webui Issues related to interactions with Web UI effort/days Estimated to take multiple days, but less than a week exp/novice Someone with a little familiarity can pick up good first issue Good issue for new contributors help wanted Seeking public contribution on this issue kind/enhancement A net-new feature or improvement to an existing feature P3 Low: Not priority right now status/deferred Conscious decision to pause or backlog topic/design-ux UX strategy, research, not solely visual design
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat: option to opt-in for bleeding edge ipfs-webui ipfs/ipfs-companion
2 participants
@lidel @jessicaschilling